From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <linux@roeck-us.net>) id 1c3b4r-00026Q-AV
	for qemu-devel@nongnu.org; Sun, 06 Nov 2016 22:58:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <linux@roeck-us.net>) id 1c3b4o-0001hk-8j
	for qemu-devel@nongnu.org; Sun, 06 Nov 2016 22:58:33 -0500
Received: from bh-25.webhostbox.net ([208.91.199.152]:41654)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <linux@roeck-us.net>) id 1c3b4o-0001gF-3s
	for qemu-devel@nongnu.org; Sun, 06 Nov 2016 22:58:30 -0500
Date: Sun, 6 Nov 2016 19:58:25 -0800
From: Guenter Roeck <linux@roeck-us.net>
Message-ID: <20161107035825.GA26942@roeck-us.net>
References: <20161025195743.4558-1-marex@denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161025195743.4558-1-marex@denx.de>
Subject: Re: [Qemu-devel] [V6, 2/7] nios2: Add architecture emulation support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marek Vasut <marex@denx.de>
Cc: qemu-devel@nongnu.org, Jeff Da Silva <jdasilva@altera.com>, Chris Wulff <crwulff@gmail.com>, Sandra Loosemore <sandra@codesourcery.com>, Yves Vandervennet <yvanderv@altera.com>, Ley Foon Tan <lftan@altera.com>, Richard Henderson <rth@twiddle.net>

On Tue, Oct 25, 2016 at 09:57:43PM +0200, Marek Vasut wrote:
> From: Chris Wulff <crwulff@gmail.com>
> 
> Add support for emulating Altera NiosII R1 architecture into qemu.
> This patch is based on previous work by Chris Wulff from 2012 and
> updated to latest mainline QEMU.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chris Wulff <crwulff@gmail.com>
> Cc: Jeff Da Silva <jdasilva@altera.com>
> Cc: Ley Foon Tan <lftan@altera.com>
> Cc: Sandra Loosemore <sandra@codesourcery.com>
> Cc: Yves Vandervennet <yvanderv@altera.com>
> ---
> V3: Thorough cleanup, deal with the review comments all over the place
> V4: - Use extract32()
>     - Fix gen_goto_tb() , suppress tcg_gen_goto_tb()
>     - Clean up gen_check_supervisor() helper
>     - Use TCGMemOp type for flags
>     - Drop jump labels from wrctl/rdctl
>     - More TCG cleanup
> V5: - Simplify load/store handling
>     - Handle loads into R_ZERO from protected page, add comment
> V6: - Fix division opcode handling
>     - Add missing disas handling
>     - V5 review comments cleanup
> ---
[ ... ]

> diff --git a/target-nios2/cpu.h b/target-nios2/cpu.h
> new file mode 100644
> index 0000000..17c9a0f
[ ... ]

> +static inline void cpu_get_tb_cpu_state(CPUNios2State *env, target_ulong *pc,
> +                                        target_ulong *cs_base, uint32_t *flags)
> +{
> +    *pc = env->regs[R_PC];
> +    *cs_base = 0;
> +    *flags = (env->regs[CR_STATUS] & (CR_STATUS_EH | CR_STATUS_U));
> +}
> +
> +#endif /* CPU_NIOS2_H */
> +

The empty line at the end results in a whitespace message from git.

Guenter