From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3fnc-00011v-Eb for qemu-devel@nongnu.org; Mon, 07 Nov 2016 04:01:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3fnX-0008Db-HC for qemu-devel@nongnu.org; Mon, 07 Nov 2016 04:01:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44416) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3fnX-0008Cu-3j for qemu-devel@nongnu.org; Mon, 07 Nov 2016 04:00:59 -0500 Date: Mon, 7 Nov 2016 17:00:55 +0800 From: Fam Zheng Message-ID: <20161107090055.GC10158@lemon> References: <20161102162103.66480-1-cornelia.huck@de.ibm.com> <572b71d8-eaef-d06c-be86-e8c5287f2568@redhat.com> <20161107073648.GB10158@lemon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, stefanha@gmail.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, Cornelia Huck , alex.bennee@linaro.org On Mon, 11/07 09:34, Paolo Bonzini wrote: > > > On 07/11/2016 08:36, Fam Zheng wrote: > > On Fri, 11/04 10:06, Paolo Bonzini wrote: > >> > >> > >> On 02/11/2016 17:21, Cornelia Huck wrote: > >>> Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") > >>> attempted to convert all users of run_on_cpu to use the new > >>> run_on_cpu_data type. It missed to change the called sigp_* routines, > >>> however. Fix that. > >>> > >>> Fixes: 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") > >>> Signed-off-by: Cornelia Huck > >>> --- > >>> Peter, Stefan: This fixes building for s390x which is currently > >>> broken (at least with kvm enabled). Two questions: > >>> - Will you pick this up as a build fix, or should I do a pull req? > >>> - Can we do anything more to catch errors like this? > >> > >> Fam, can we use the linux-user support in tests/docker to build QEMU > >> with KVM support on ARM/MIPS/s390? It would be already much better, > >> even if it obviously cannot run with KVM. > > > > I suppose you are asking adding coverage to patchew? (If you are asking if > > tests/docker can use linux-user to do that, the answer is yes, as long as there > > is debootstrap support for that platform.) > > No, not necessarily---I use tests/docker myself before sending pull > requests, and these days Peter only rejects my pull request for macOS > problems. :) OK. The command is something along: $ arch=mips $ make docker-test-quick@debian-bootstrap \ DEB_ARCH=$arch DEB_TYPE=stable \ EXECUTABLE=/usr/bin/qemu-$arch \ V=1 J=8 (FWIW, to avoid ld.so collision with the $arch binaries in the image, I only use statically compiled qemu-user.) Fam