From: Stefan Hajnoczi <stefanha@gmail.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: peter.maydell@linaro.org, borntraeger@de.ibm.com, agraf@suse.de,
jfrei@linux.vnet.ibm.com, alex.bennee@linaro.org,
pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions
Date: Mon, 7 Nov 2016 11:34:00 +0000 [thread overview]
Message-ID: <20161107113400.GF5036@stefanha-x1.localdomain> (raw)
In-Reply-To: <20161102162103.66480-1-cornelia.huck@de.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On Wed, Nov 02, 2016 at 05:21:03PM +0100, Cornelia Huck wrote:
> Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type")
> attempted to convert all users of run_on_cpu to use the new
> run_on_cpu_data type. It missed to change the called sigp_* routines,
> however. Fix that.
>
> Fixes: 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type")
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> Peter, Stefan: This fixes building for s390x which is currently
> broken (at least with kvm enabled). Two questions:
> - Will you pick this up as a build fix, or should I do a pull req?
> - Can we do anything more to catch errors like this?
> ---
> target-s390x/kvm.c | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
Thanks, applied!
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-11-07 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 16:21 [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions Cornelia Huck
2016-11-04 8:23 ` Christian Borntraeger
2016-11-04 8:25 ` Christian Borntraeger
2016-11-04 9:06 ` Paolo Bonzini
2016-11-07 7:36 ` Fam Zheng
2016-11-07 8:34 ` Paolo Bonzini
2016-11-07 9:00 ` Fam Zheng
2016-11-07 11:34 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107113400.GF5036@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).