qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"
Date: Mon, 7 Nov 2016 12:57:10 +0000	[thread overview]
Message-ID: <20161107125710.GH5036@stefanha-x1.localdomain> (raw)
In-Reply-To: <20161102175539.4375-1-mreitz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote:
> See patch 3 for the reason why we have actually never supported TFTP at
> all (except for very small files (i.e. below 256 kB or so)).

I agree with dropping TFTP from the curl block driver but for the
record:

TFTP is not good for large files anyway - performance is poor due to the
lock-step ACK protocol.  It is used for <256 KB files to chainload
Network Boot Programs (PXE) so the small file scenario is actually
realistic for TFTP.

In that use case it doesn't really make sense to use a block device in
QEMU though.  The guest would do the TFTP itself so I don't see a need
to offer the protocol in the curl block driver.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

      parent reply	other threads:[~2016-11-07 12:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 17:55 [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support" Max Reitz
2016-11-02 17:55 ` [Qemu-devel] [PATCH for-2.8? 1/3] qemu-options: Drop mentions of curl's TFTP support Max Reitz
2016-11-02 18:20   ` Jeff Cody
2016-11-02 17:55 ` [Qemu-devel] [PATCH for-2.8? 2/3] qapi: Drop curl's TFTP protocol Max Reitz
2016-11-02 18:22   ` Jeff Cody
2016-11-02 17:55 ` [Qemu-devel] [PATCH for-2.8? 3/3] block/curl: Drop TFTP "support" Max Reitz
2016-11-02 18:22   ` Jeff Cody
2016-11-02 18:20 ` [Qemu-devel] [PATCH for-2.8? 0/3] " Jeff Cody
2016-11-03  7:56 ` Markus Armbruster
2016-11-04 16:53   ` Max Reitz
2016-11-07  8:20     ` Markus Armbruster
2016-11-07 15:42       ` Max Reitz
2016-11-08  7:14         ` Markus Armbruster
2016-11-09 19:15           ` Jeff Cody
2016-11-11 19:46             ` Max Reitz
2016-11-14 18:54               ` Jeff Cody
2016-11-03  9:42 ` Kevin Wolf
2016-11-07 12:57 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161107125710.GH5036@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).