From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3jUG-00077u-7W for qemu-devel@nongnu.org; Mon, 07 Nov 2016 07:57:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3jUF-000663-Fn for qemu-devel@nongnu.org; Mon, 07 Nov 2016 07:57:20 -0500 Date: Mon, 7 Nov 2016 12:57:10 +0000 From: Stefan Hajnoczi Message-ID: <20161107125710.GH5036@stefanha-x1.localdomain> References: <20161102175539.4375-1-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8sldprk+5E/pDEv" Content-Disposition: inline In-Reply-To: <20161102175539.4375-1-mreitz@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, Kevin Wolf , Markus Armbruster , qemu-devel@nongnu.org --a8sldprk+5E/pDEv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). I agree with dropping TFTP from the curl block driver but for the record: TFTP is not good for large files anyway - performance is poor due to the lock-step ACK protocol. It is used for <256 KB files to chainload Network Boot Programs (PXE) so the small file scenario is actually realistic for TFTP. In that use case it doesn't really make sense to use a block device in QEMU though. The guest would do the TFTP itself so I don't see a need to offer the protocol in the curl block driver. Stefan --a8sldprk+5E/pDEv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYIHomAAoJEJykq7OBq3PIhwkH/2wM1AHu72XOqSZGtDGMN8w1 KUYwFrKE5grzKBehi7zIosfuyVcvmilM3Z0coZDxzBjdLMmGXSyrq3RNCxuULPsj hKMkOQJW75ZS7pphFt87ofqnK9nLRjCZpZ+ygiKPr4LBFopXeglf236G6qLUctzl 9+BmFiAHGYpS3+58amhjn6Hb3RxB76Lk1tGB+oh7KoyY4jCXvj+QME4zs0okF18B pfi7Ix1tyJsh1K+xu6bqudDOcuxI5injvc6TQzxIRSOdfunvp2/XuFTlhwRY/3gH iP6KQi3Fhuvc4Dzp27bs+8kPNOQqgv7KWmTzbW1Oe0MyziNDJm+La/mCn20Gg9I= =3EQp -----END PGP SIGNATURE----- --a8sldprk+5E/pDEv--