From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3pcS-0002MM-T3 for qemu-devel@nongnu.org; Mon, 07 Nov 2016 14:30:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3pcO-0001by-6J for qemu-devel@nongnu.org; Mon, 07 Nov 2016 14:30:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50196) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3pcO-0001am-1S for qemu-devel@nongnu.org; Mon, 07 Nov 2016 14:30:08 -0500 Date: Mon, 7 Nov 2016 19:30:02 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20161107193001.GA1155@work-vm> References: <20161027153217.16984-1-dgilbert@redhat.com> <20161027153217.16984-9-dgilbert@redhat.com> <20161030145158.GF3671@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161030145158.GF3671@var.home> Subject: Re: [Qemu-devel] [PATCH 8/8] slirp: VMStatify remaining except for loop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com, jan.kiszka@siemens.com, duanj@linux.vnet.ibm.com * Samuel Thibault (samuel.thibault@gnu.org) wrote: > Hello, > > Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:17 +0100, wrote: > > This converts the remaining components, except for the loop, to VMState. > > > > + /* TODO: Add loop */ > > + VMSTATE_UINT16_V(ip_id, Slirp, 2), > > + VMSTATE_STRUCT_ARRAY(bootp_clients, Slirp, NB_BOOTP_CLIENTS, 3, > > + vmstate_slirp_bootp_client, BOOTPClient), > > I don't understand: doesn't the NB_BOOTP_CLIENTS parameter here > implement the loop? That implements one loop; the TODO is to add the loop over slirp->exec_list that's at the top of slirp_state_save; once we find a way of adding that loop then the whole of slirp_state_save/load disappears and we're left with just the VMStateDescription. Dave > Samuel -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK