From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3qNR-0005TP-IY for qemu-devel@nongnu.org; Mon, 07 Nov 2016 15:18:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3qNM-0008G0-GS for qemu-devel@nongnu.org; Mon, 07 Nov 2016 15:18:45 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33649 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3qNM-0008FU-Al for qemu-devel@nongnu.org; Mon, 07 Nov 2016 15:18:40 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA7KE5N7027476 for ; Mon, 7 Nov 2016 15:18:39 -0500 Received: from e24smtp05.br.ibm.com (e24smtp05.br.ibm.com [32.104.18.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 26jup3yjhf-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 07 Nov 2016 15:18:39 -0500 Received: from localhost by e24smtp05.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Nov 2016 18:18:37 -0200 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 5C4481DC006E for ; Mon, 7 Nov 2016 15:18:35 -0500 (EST) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay01.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uA7KIZv94800672 for ; Mon, 7 Nov 2016 18:18:35 -0200 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uA7KIYAb009983 for ; Mon, 7 Nov 2016 18:18:34 -0200 Date: Mon, 7 Nov 2016 18:18:25 -0200 From: joserz@linux.vnet.ibm.com References: <1478452528-13684-1-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Message-Id: <20161107201825.GA4972@pacoca> Subject: Re: [Qemu-devel] [PATCH Risu v2 0/9] Risu support for PPC64LE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Mon, Nov 07, 2016 at 04:43:38PM +0000, Peter Maydell wrote: > On 6 November 2016 at 17:15, Jose Ricardo Ziviani > wrote: > > v2: > > - smaller commits > > - improved registers comparison > > - improved code style > > - fixed copyright lines > > > > TODOs: > > - improve load/store instruction generation (risugen) > > - improve initial random values for FP and Vector regs (risugen) > > - make write_test_code() generic (risugen) > > The files risu_reginfo_ppc64le.h and ppc64.risu both still > claim to be copyright Linaro Limited. Please can you confirm that > I should change those to read 'Copyright (c) IBM Corp, 2016' > like the other new files you have written? > > I've also written a trivial fix which uses 'sort keys %insn_details' > rather than just 'keys %insn_details' so that the output binary > remains the same if you run risugen twice with the same arguments; > I then had to propagate that fix to the new places where that > code got copied. > > It would be good to have a 'utils' module which gets used > by the arch specific modules so we can avoid having duplicate > functions between all the arch specific modules, but we can > do that as a separate cleanup after this lot. > > If you give me the OK to fix up the copyright lines I can push > this patchset to risu master. > > thanks > -- PMM > Hello Peter, Yes, my bad again. You can fix these copyright lines. I intend to continue working on it, so I'll create a todo list with some suggestions I have and share that with you so you can modify/add as well. Thank you very much for your review! Ziviani