From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3wTn-00054Y-It for qemu-devel@nongnu.org; Mon, 07 Nov 2016 21:49:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3wTk-0006Mf-Gw for qemu-devel@nongnu.org; Mon, 07 Nov 2016 21:49:43 -0500 Date: Tue, 8 Nov 2016 13:22:04 +1100 From: David Gibson Message-ID: <20161108022204.GE28688@umbus.fritz.box> References: <1478013888-22242-1-git-send-email-joserz@linux.vnet.ibm.com> <1478013888-22242-3-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7LkOrbQMr4cezO2T" Content-Disposition: inline In-Reply-To: <1478013888-22242-3-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 2/4] target-ppc: Implement bcdctn. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --7LkOrbQMr4cezO2T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 01, 2016 at 01:24:46PM -0200, Jose Ricardo Ziviani wrote: > bcdctn. converts from BCD to National numeric format. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. >=20 > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 48 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 4 ++++ > 3 files changed, 53 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 3b23eed..33286c6 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -372,6 +372,7 @@ DEF_HELPER_4(vpermxor, void, avr, avr, avr, avr) > DEF_HELPER_4(bcdadd, i32, avr, avr, avr, i32) > DEF_HELPER_4(bcdsub, i32, avr, avr, avr, i32) > DEF_HELPER_3(bcdcfn, i32, avr, avr, i32) > +DEF_HELPER_3(bcdctn, i32, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 605cfc7..3c21173 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2515,6 +2515,15 @@ static uint16_t get_national_digit(ppc_avr_t *reg,= int n) > #endif > } > =20 > +static void set_national_digit(ppc_avr_t *reg, uint8_t val, int n) > +{ > +#if defined(HOST_WORDS_BIGENDIAN) > + reg->u16[8 - n] =3D val; > +#else > + reg->u16[n] =3D val; > +#endif > +} > + > static int bcd_cmp_mag(ppc_avr_t *a, ppc_avr_t *b) > { > int i; > @@ -2681,6 +2690,45 @@ uint32_t helper_bcdcfn(ppc_avr_t *r, ppc_avr_t *b,= uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdctn(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps) > +{ > + int i; > + int cr =3D 0; > + int sgnb =3D bcd_get_sgn(b); > + int invalid =3D (sgnb =3D=3D 0); > + ppc_avr_t ret =3D { .u64 =3D { 0, 0 } }; > + > + int eq_flag =3D (b->u64[HI_IDX] =3D=3D 0) && ((b->u64[LO_IDX] >> 4) = =3D=3D 0); You can simplify this, and several pieces below by using the bcd_cmp_zero() function you introduced in the previous patch. > + int ox_flag =3D (b->u64[HI_IDX] !=3D 0) || ((b->u64[LO_IDX] >> 32) != =3D 0); > + > + for (i =3D 1; i < 8; i++) { > + set_national_digit(&ret, 0x30 + bcd_get_digit(b, i, &invalid), i= ); > + > + if (unlikely(invalid)) { > + break; > + } > + } > + set_national_digit(&ret, (sgnb =3D=3D -1) ? NATIONAL_NEG : NATIONAL_= PLUS, 0); > + > + if (!eq_flag) { > + cr =3D (sgnb =3D=3D -1) ? 1 << CRF_LT : 1 << CRF_GT; > + } else { > + cr =3D 1 << CRF_EQ; > + } > + > + if (ox_flag) { > + cr |=3D 1 << CRF_SO; > + } > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + *r =3D ret; > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 50abfaf..d5953a6 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -971,10 +971,14 @@ static void gen_##op(DisasContext *ctx) = \ > GEN_BCD(bcdadd) > GEN_BCD(bcdsub) > GEN_BCD2(bcdcfn) > +GEN_BCD2(bcdctn) > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > switch (opc4(ctx->opcode)) { > + case 5: > + gen_bcdctn(ctx); > + break; > case 7: > gen_bcdcfn(ctx); > break; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --7LkOrbQMr4cezO2T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYITbJAAoJEGw4ysog2bOSNuQP/0inRwbhnI2fdYvClAtOrDRN qYwns0AoH1LPd6zqDVJxtzLEjRnZx3F8X51+H6HEF56KOQEJsn1wfijXIwXVcsSz TdSaxbjfjC2YTe9Ayf0vjANXLe546rmN3Zmk2d54hNwRGCkq1HYdBkbknUM1/QP3 P7qPfezi82V+2LK0n2AntniJrXgTdJfmP6AXveJKKbcu12tnGLCxG8AtWA4ypdY2 w43S/ptSv+NXoX4vJtDNFRs7CN24W/YNIRhl2Zcz/gZly73U0i1QJpNmRf8SJfAR Mc/yWmGCTq5WykPn2K2s4MfY/dAhkprfQTW7ukoK7ZflZr3BwnamYoWI/9etKYkV yzt5lklRkL4pog4a8dwa7i4sOODdM3ZI0zJQ8rcXXn5ApT5yMLpO+TMduQEa7o6U I3vkNDeLoQzjGwFK1iuerh663qMiTY1aFjNqqOrvSPNB1v6+oGuXRaJ4W+5PAUPP ERSYDRW8dJoCEwopgMudfjb9v6wdtbVk6Uktp1hvoJxM/9lAZxmUzlD44IWgPjGt qj0LFbK0TircegWqAPGJCEvOFHoxTdZOqgCuzEDLUojyN48b44cJi/99bMsazBpN 2k/iOvkpng6i4YVHEIof6w1ejcqdGDKsVGuSZyaiptbvJBYsjyxsiDKvdMeb5Qbs p8p0IWEbti5MuI5N7Tm2 =fJmp -----END PGP SIGNATURE----- --7LkOrbQMr4cezO2T--