From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3zeF-0002SE-81 for qemu-devel@nongnu.org; Tue, 08 Nov 2016 01:12:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3zeC-0006Kx-1s for qemu-devel@nongnu.org; Tue, 08 Nov 2016 01:12:43 -0500 Received: from ozlabs.org ([103.22.144.67]:38587) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3zeB-0006Kq-Ey for qemu-devel@nongnu.org; Tue, 08 Nov 2016 01:12:39 -0500 Date: Tue, 8 Nov 2016 17:12:30 +1100 From: David Gibson Message-ID: <20161108061230.GY28688@umbus.fritz.box> References: <1476678204-11511-1-git-send-email-david@gibson.dropbear.id.au> <1476678204-11511-4-git-send-email-david@gibson.dropbear.id.au> <878tszr1c6.fsf@dusky.pond.sub.org> <9d852a99-806e-2c1d-da7f-adbce33eb96a@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7tPHY7RFL01rOa8z" Content-Disposition: inline In-Reply-To: <9d852a99-806e-2c1d-da7f-adbce33eb96a@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] Split ISA and sysbus versions of m48t59 device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Markus Armbruster , pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com --7tPHY7RFL01rOa8z Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 04, 2016 at 08:28:25AM -0500, Eric Blake wrote: > On 11/04/2016 05:22 AM, Markus Armbruster wrote: > > Needs a rebase. First error: > >=20 > > CC hw/timer/m48t59.o > > In file included from /work/armbru/qemu/include/exec/cpu-common.h:7:0, > > from /work/armbru/qemu/include/exec/memory.h:24, > > from /work/armbru/qemu/include/hw/isa/isa.h:6, > > from /work/armbru/qemu/hw/timer/m48t59-isa.c:25: > > /work/armbru/qemu/include/exec/hwaddr.h:11:9: error: unknown type name = =E2=80=98uint64_t=E2=80=99 > > typedef uint64_t hwaddr; > > ^ > >=20 >=20 > >> index 0000000..3a521dc > >> --- /dev/null > >> +++ b/hw/timer/m48t59-isa.c >=20 > >> + * THE SOFTWARE. > >> + */ > >> +#include "hw/isa/isa.h" >=20 > Probably because you forgot osdep.h as the first include. That, plus I stupidly re-used the same double-include prevention symbol from an existing header file. I've fixed that up in my branch now. Of course, I still have no idea who I really need to convince to actually get this merged. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --7tPHY7RFL01rOa8z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYIWzLAAoJEGw4ysog2bOS3PQQAOQYSMd93FV1dsJSyzsBtMTH BzJ9JJurtswRe316G8IRk/g6fJgVEVU3y9nk6812FV9xJh5mqSW3Uv3pY6MKkYlr JSo7jthGPklkdbrqziZrjs7FjZebiLuq9X1DtAlOvXHzuOm8Qtk32u1GSR1E+duo Od+yirXlcLP9sl8zXTyClHDQ0bI3FKEMbN4/ebzb49E2ruHwL61cl5hqiQPa5mQs D2GxFxb0pVS3sSesvOqPv9GV23NR0FKqSr1zUJmdJuL8PBTfWJ7ry1AlEkBNLvHD rgvRnDu5P2jJMcplhviglRjQYuDCGu7V/V5GSvWPslM97VghSQAcstTdLCwjlzgA Uee3Y3tvO/bLqT6NqPNR95PMPwh4P35zgK0tRwUfVXBCQd7YD1jgn2DY29pEbiPq deWPEBxiV4LndxM3Fz0f7Oh2IbuUMno4VL0/2MmX5TDpgTxR6C6nQ9sYDTGvDMjH EHKlOj21ChkALdGKZEX2Eoz91FpHxodYV+IbENriLaFfuVxaN6wjSDbA5Kw3Cwzl pIDZ+hP2xVdenSYOG8VoLs1V+DIzLpAWRNOA2QFOhyd/b3fMxJaP63cVdVWAysPD cHGD06PFQsFI+i9pqu8biE5jOBcabiBchTl+rp0lsHvZfd89VWgttOYDAGJ0sp0f BZbXOVe3UU8i1m2RJK4k =np1Z -----END PGP SIGNATURE----- --7tPHY7RFL01rOa8z--