From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Oiy-0004SC-U4 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 03:59:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Oit-0007Zw-VR for qemu-devel@nongnu.org; Wed, 09 Nov 2016 03:59:17 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52404 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4Oit-0007ZI-PT for qemu-devel@nongnu.org; Wed, 09 Nov 2016 03:59:11 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA98x40K010021 for ; Wed, 9 Nov 2016 03:59:11 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 26m03t9waf-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 09 Nov 2016 03:59:10 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Nov 2016 08:59:06 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id CAEBB219005E for ; Wed, 9 Nov 2016 08:58:16 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uA98x2UW9634232 for ; Wed, 9 Nov 2016 08:59:02 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uA98x19P002446 for ; Wed, 9 Nov 2016 01:59:02 -0700 Date: Wed, 9 Nov 2016 09:58:59 +0100 From: Cornelia Huck In-Reply-To: <20161108201019.GM2378@var.home> References: <20161107220741.GL2367@var.home> <20161108123449.0e031320.cornelia.huck@de.ibm.com> <20161108201019.GM2378@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-Id: <20161109095859.0be2b487.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: Peter Maydell , Michal Suchanek , QEMU Developers On Tue, 8 Nov 2016 21:10:19 +0100 Samuel Thibault wrote: > Cornelia Huck, on Tue 08 Nov 2016 12:34:49 +0100, wrote: > > > diff --git a/configure b/configure > > > index fd6f898..e200aa8 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -2926,7 +2926,7 @@ if test "$curses" !=3D "no" ; then > > > curses_inc_list=3D"$($pkg_config --cflags ncurses 2>/dev/null):" > > > curses_lib_list=3D"$($pkg_config --libs ncurses 2>/dev/null):-lp= dcurses" > > > else > > > - curses_inc_list=3D"$($pkg_config --cflags ncursesw 2>/dev/null):" > > > + curses_inc_list=3D"$($pkg_config --cflags ncursesw 2>/dev/null):= -I/usr/include/ncursesw:" > >=20 > > This arrives at > >=20 > > curses_inc_list=3D":-I/usr/include/ncursesw:" > >=20 > > which causes the parser below to start with an empty curses_inc (with : > > as separator). >=20 > Yes, this is expected. >=20 > > configure fails as before (with -Werror; passes without). >=20 > Ah! > So are you getting the following message? >=20 > =E2=80=9C > configure test passed without -Werror but failed with -Werror. > This is probably a bug in the configure script. The failing command > will be at the bottom of config.log. > You can run configure with --disable-werror to bypass this check. > =E2=80=9D >=20 > If so, you should really have said it, I was really wondering how > configure could just stopping in your case. That does explain things > indeed. I said so in my very first mail for the issue... appears I was unclear. >=20 > Could you try the attached patch? It should be able to really fail > without Werror too. With your patch, configure runs through and detects curses=3Dno. Not sure that's correct, though: SLES12SP1 _does_ have curses, but not a .pc file for ncursesw. I don't know enough about curses to say whether it should be that way...