[Qemu-devel] [PATCH 0/2] Current Travis patches

[Qemu-devel] [PATCH 0/2] Current Travis patches

[Alex Bennée]

Hi,

Not much here but since Daniel sped up the build by trimming out most
of the clang mirrors of gcc I added one additional clang build which
uses the current stable branch. Hopefully this still gives us enough
coverage.

As this speeds up testing on merges and doesn't affect QEMU code
itself I'll ask if we can merge this in the 2.8 cycle? If so I'll send
a pull request in a few days assuming no objection to the patches
themselves.

Alex Bennée (1):
  travis: add Trusty with clang stable build

Daniel P. Berrange (1):
  travis: trim out most clang builds

 .travis.yml | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

-- 
2.10.1

[Qemu-devel] [PATCH 1/2] travis: trim out most clang builds

[Alex Bennée]

From: "Daniel P. Berrange" <berrange@redhat.com>

We test with both gcc and clang in order to detect cases
where clang issues warnings that gcc misses. To achieve
this though we don't need to build QEMU in multiple
different configurations. Just a single clang-on-linux
build will be sufficient, if we have an "all enabled"
config.

This cuts the number of build jobs from 21 to 16,
reducing the load imposed on shared Travis CI infra.
This will make it practical to enable jobs for other
interesting & useful configurations without DOS'ing
Travis to much.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 9916178..0706b9a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,7 +4,6 @@ python:
   - "2.4"
 compiler:
   - gcc
-  - clang
 cache: ccache
 addons:
   apt:
@@ -68,6 +67,9 @@ script:
   - make -j3 && ${TEST_CMD}
 matrix:
   include:
+    # Test with CLang for compile portability
+    - env: CONFIG=""
+      compiler: clang
     # gprof/gcov are GCC features
     - env: CONFIG="--enable-gprof --enable-gcov --disable-pie"
       compiler: gcc
-- 
2.10.1

[Qemu-devel] [PATCH 2/2] travis: add Trusty with clang stable build

[Alex Bennée]

Although we've reduced the matrix to avoid repeating clang builds we can
still add an additional clang build to use the latest stable version of
clang which will typically be available on current distros.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 0706b9a..d83e2d4 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -103,6 +103,26 @@ matrix:
         - sudo apt-get build-dep -qq qemu
         - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
         - git submodule update --init --recursive
+    # Trusty build with latest stable clang
+    - env: CONFIG=""
+      sudo: required
+      addons:
+      dist: trusty
+      language: generic
+      compiler: none
+      env:
+        - COMPILER_NAME=clang CXX=clang++-3.9 CC=clang-3.9
+        - CONFIG="--cc=clang-3.9 --cxx=clang++-3.9"
+      before_install:
+        - wget -nv -O - http://llvm.org/apt/llvm-snapshot.gpg.key | sudo apt-key add -
+        - sudo apt-add-repository -y 'deb http://llvm.org/apt/trusty llvm-toolchain-trusty-3.9 main'
+        - sudo apt-get update -qq
+        - sudo apt-get install -qq -y clang-3.9
+        - sudo apt-get build-dep -qq qemu
+        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
+        - git submodule update --init --recursive
+      before_script:
+        - ./configure ${CONFIG} || cat config.log
     # Using newer GCC with sanitizers
     - addons:
         apt:
-- 
2.10.1

Re: [Qemu-devel] [PATCH 0/2] Current Travis patches

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On Wed, Nov 09, 2016 at 12:11:55PM +0000, Alex Bennée wrote:
> Hi,
> 
> Not much here but since Daniel sped up the build by trimming out most
> of the clang mirrors of gcc I added one additional clang build which
> uses the current stable branch. Hopefully this still gives us enough
> coverage.
> 
> As this speeds up testing on merges and doesn't affect QEMU code
> itself I'll ask if we can merge this in the 2.8 cycle? If so I'll send
> a pull request in a few days assuming no objection to the patches
> themselves.
> 
> Alex Bennée (1):
>   travis: add Trusty with clang stable build
> 
> Daniel P. Berrange (1):
>   travis: trim out most clang builds
> 
>  .travis.yml | 24 +++++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)

Despite .travis.yml not affecting the QEMU binary I want to stick to the
"bug fixes only" soft freeze policy for the 2.8 release.  Please queue
it for 2.9.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH 0/2] Current Travis patches

[Alex Bennée]

Stefan Hajnoczi <stefanha@redhat.com> writes:

> On Wed, Nov 09, 2016 at 12:11:55PM +0000, Alex Bennée wrote:
>> Hi,
>>
>> Not much here but since Daniel sped up the build by trimming out most
>> of the clang mirrors of gcc I added one additional clang build which
>> uses the current stable branch. Hopefully this still gives us enough
>> coverage.
>>
>> As this speeds up testing on merges and doesn't affect QEMU code
>> itself I'll ask if we can merge this in the 2.8 cycle? If so I'll send
>> a pull request in a few days assuming no objection to the patches
>> themselves.
>>
>> Alex Bennée (1):
>>   travis: add Trusty with clang stable build
>>
>> Daniel P. Berrange (1):
>>   travis: trim out most clang builds
>>
>>  .travis.yml | 24 +++++++++++++++++++++++-
>>  1 file changed, 23 insertions(+), 1 deletion(-)
>
> Despite .travis.yml not affecting the QEMU binary I want to stick to the
> "bug fixes only" soft freeze policy for the 2.8 release.  Please queue
> it for 2.9.

Fair enough, I shall hold on to them for now.

>
> Stefan


--
Alex Bennée