From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Vts-0007Ob-Mn for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:39:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Vtp-0003XZ-Kw for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:39:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36018) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4Vtp-0003X7-F1 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:38:57 -0500 Date: Wed, 9 Nov 2016 17:38:53 +0100 From: Igor Mammedov Message-ID: <20161109173853.50b8970a@nial.brq.redhat.com> In-Reply-To: <1478517229-140028-5-git-send-email-guangrong.xiao@linux.intel.com> References: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com> <1478517229-140028-5-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/14] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Mon, 7 Nov 2016 19:13:39 +0800 Xiao Guangrong wrote: > as it is never called when nvdimm hotplug happens > > Suggested-by: Igor Mammedov > Signed-off-by: Xiao Guangrong Reviewed-by: Igor Mammedov > --- > hw/i386/pc.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 8ef3920..97e23c4 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1761,12 +1761,6 @@ static void pc_dimm_unplug(HotplugHandler *hotplug_dev, > HotplugHandlerClass *hhc; > Error *local_err = NULL; > > - if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { > - error_setg(&local_err, > - "nvdimm device hot unplug is not supported yet."); > - goto out; > - } > - > hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); > hhc->unplug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err); >