From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Vv2-0008Un-R3 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:40:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Vuz-000407-4n for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:40:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45796) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4Vuy-0003zd-VP for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:40:09 -0500 Date: Wed, 9 Nov 2016 17:40:05 +0100 From: Igor Mammedov Message-ID: <20161109174005.251f7446@nial.brq.redhat.com> In-Reply-To: <1478517229-140028-9-git-send-email-guangrong.xiao@linux.intel.com> References: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com> <1478517229-140028-9-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Mon, 7 Nov 2016 19:13:43 +0800 Xiao Guangrong wrote: > inline buf_size to refine the code a bit > > Suggested-by: Igor Mammedov > Signed-off-by: Xiao Guangrong > --- > hw/acpi/nvdimm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Igor Mammedov > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index f2c0659..148999e 100644 > --- a/hw/acpi/nvdimm.c > +++ b/hw/acpi/nvdimm.c > @@ -1134,11 +1134,9 @@ static void nvdimm_build_fit(Aml *dev) > aml_append(ifctx, aml_return(aml_buffer(0, NULL))); > aml_append(method, ifctx); > > - aml_append(method, aml_store(aml_shiftleft(buf_size, aml_int(3)), > - buf_size)); > aml_append(method, aml_create_field(buf, > aml_int(4 * BITS_PER_BYTE), /* offset at byte 4.*/ > - buf_size, "BUFF")); > + aml_shiftleft(buf_size, aml_int(3)), "BUFF")); > aml_append(method, aml_return(aml_name("BUFF"))); > aml_append(dev, method); >