From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4VvG-0000EK-GH for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:40:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4VvD-000434-Dp for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:40:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60542) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4VvD-00042w-7q for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:40:23 -0500 Date: Wed, 9 Nov 2016 17:40:19 +0100 From: Igor Mammedov Message-ID: <20161109174019.64834a75@nial.brq.redhat.com> In-Reply-To: <1478517229-140028-10-git-send-email-guangrong.xiao@linux.intel.com> References: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com> <1478517229-140028-10-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/14] nvdimm acpi: rename nvdimm_acpi_hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Mon, 7 Nov 2016 19:13:44 +0800 Xiao Guangrong wrote: > Rename it to nvdimm_plug() > > Suggested-by: Igor Mammedov > Signed-off-by: Xiao Guangrong Reviewed-by: Igor Mammedov > --- > hw/acpi/nvdimm.c | 2 +- > hw/i386/pc.c | 2 +- > include/hw/mem/nvdimm.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index 148999e..7733f14 100644 > --- a/hw/acpi/nvdimm.c > +++ b/hw/acpi/nvdimm.c > @@ -380,7 +380,7 @@ static void nvdimm_build_fit_buffer(NvdimmFitBuffer *fit_buf) > fit_buf->dirty = true; > } > > -void nvdimm_acpi_hotplug(AcpiNVDIMMState *state) > +void nvdimm_plug(AcpiNVDIMMState *state) > { > nvdimm_build_fit_buffer(&state->fit_buf); > } > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 97e23c4..edc96a6 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1716,7 +1716,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev, > } > > if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { > - nvdimm_acpi_hotplug(&pcms->acpi_nvdimm_state); > + nvdimm_plug(&pcms->acpi_nvdimm_state); > } > > hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); > diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h > index 60585c3..03e1ff9 100644 > --- a/include/hw/mem/nvdimm.h > +++ b/include/hw/mem/nvdimm.h > @@ -130,6 +130,6 @@ void nvdimm_init_acpi_state(AcpiNVDIMMState *state, MemoryRegion *io, > void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data, > BIOSLinker *linker, AcpiNVDIMMState *state, > uint32_t ram_slots); > -void nvdimm_acpi_hotplug(AcpiNVDIMMState *state); > +void nvdimm_plug(AcpiNVDIMMState *state); > void nvdimm_acpi_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev); > #endif