From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Vvy-0000o9-HP for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Vvx-0004Mk-L7 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33930) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4Vvx-0004Mf-Fa for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:09 -0500 Date: Wed, 9 Nov 2016 17:41:05 +0100 From: Igor Mammedov Message-ID: <20161109174105.01885b40@nial.brq.redhat.com> In-Reply-To: <1478517229-140028-12-git-send-email-guangrong.xiao@linux.intel.com> References: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com> <1478517229-140028-12-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/14] nvdimm acpi: fix two comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Mon, 7 Nov 2016 19:13:46 +0800 Xiao Guangrong wrote: > fixed the English issue and code-style issue > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Xiao Guangrong Reviewed-by: Igor Mammedov > --- > hw/acpi/nvdimm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index c7e7744..6f6f51f 100644 > --- a/hw/acpi/nvdimm.c > +++ b/hw/acpi/nvdimm.c > @@ -479,7 +479,7 @@ QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncSetLabelDataIn) + > offsetof(NvdimmDsmIn, arg3) > 4096); > > struct NvdimmFuncReadFITIn { > - uint32_t offset; /* the offset of FIT buffer. */ > + uint32_t offset; /* the offset into FIT buffer. */ > } QEMU_PACKED; > typedef struct NvdimmFuncReadFITIn NvdimmFuncReadFITIn; > QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncReadFITIn) + > @@ -578,7 +578,7 @@ static void nvdimm_dsm_reserved_root(AcpiNVDIMMState *state, NvdimmDsmIn *in, > case 0x0: > nvdimm_dsm_function0(0x1 | 1 << 1 /* Read FIT */, dsm_mem_addr); > return; > - case 0x1 /*Read FIT */: > + case 0x1 /* Read FIT */: > nvdimm_dsm_func_read_fit(state, in, dsm_mem_addr); > return; > }