From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4VwD-00014l-RZ for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4VwC-0004P0-5W for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46442) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4VwC-0004Oq-0N for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:24 -0500 Date: Wed, 9 Nov 2016 17:41:20 +0100 From: Igor Mammedov Message-ID: <20161109174120.0354d810@nial.brq.redhat.com> In-Reply-To: <1478517229-140028-13-git-send-email-guangrong.xiao@linux.intel.com> References: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com> <1478517229-140028-13-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/14] nvdimm acpi: rename nvdimm_dsm_reserved_root List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Mon, 7 Nov 2016 19:13:47 +0800 Xiao Guangrong wrote: > Rename it to nvdimm_dsm_handle_reserved_root_method > > Suggested-by: Igor Mammedov > Signed-off-by: Xiao Guangrong Reviewed-by: Igor Mammedov > --- > hw/acpi/nvdimm.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index 6f6f51f..6692648 100644 > --- a/hw/acpi/nvdimm.c > +++ b/hw/acpi/nvdimm.c > @@ -571,8 +571,9 @@ exit: > g_free(read_fit_out); > } > > -static void nvdimm_dsm_reserved_root(AcpiNVDIMMState *state, NvdimmDsmIn *in, > - hwaddr dsm_mem_addr) > +static void > +nvdimm_dsm_handle_reserved_root_method(AcpiNVDIMMState *state, > + NvdimmDsmIn *in, hwaddr dsm_mem_addr) > { > switch (in->function) { > case 0x0: > @@ -842,7 +843,7 @@ nvdimm_dsm_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) > } > > if (in->handle == NVDIMM_QEMU_RSVD_HANDLE_ROOT) { > - nvdimm_dsm_reserved_root(state, in, dsm_mem_addr); > + nvdimm_dsm_handle_reserved_root_method(state, in, dsm_mem_addr); > goto exit; > } >