From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4VwR-0001Lb-Ku for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4VwQ-0004WK-PY for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46630) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4VwQ-0004Vs-K5 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 11:41:38 -0500 Date: Wed, 9 Nov 2016 17:41:34 +0100 From: Igor Mammedov Message-ID: <20161109174134.017edae3@nial.brq.redhat.com> In-Reply-To: <1478517229-140028-14-git-send-email-guangrong.xiao@linux.intel.com> References: <1478517229-140028-1-git-send-email-guangrong.xiao@linux.intel.com> <1478517229-140028-14-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/14] nvdimm acpi: use aml_name_decl to define named object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Mon, 7 Nov 2016 19:13:48 +0800 Xiao Guangrong wrote: > to make the code more clearer > > Suggested-by: Igor Mammedov > Signed-off-by: Xiao Guangrong Reviewed-by: Igor Mammedov > --- > hw/acpi/nvdimm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index 6692648..5f48b75 100644 > --- a/hw/acpi/nvdimm.c > +++ b/hw/acpi/nvdimm.c > @@ -1098,13 +1098,11 @@ static void nvdimm_build_fit(Aml *dev) > buf_size = aml_local(1); > fit = aml_local(2); > > - aml_append(dev, aml_create_dword_field(aml_buffer(4, NULL), > - aml_int(0), NVDIMM_DSM_RFIT_STATUS)); > + aml_append(dev, aml_name_decl(NVDIMM_DSM_RFIT_STATUS, aml_int(0))); > > /* build helper function, RFIT. */ > method = aml_method("RFIT", 1, AML_SERIALIZED); > - aml_append(method, aml_create_dword_field(aml_buffer(4, NULL), > - aml_int(0), "OFST")); > + aml_append(method, aml_name_decl("OFST", aml_int(0))); > > /* prepare input package. */ > pkg = aml_package(1);