From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4gGJ-00083z-I8 for qemu-devel@nongnu.org; Wed, 09 Nov 2016 22:42:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4gGF-0000TI-Ek for qemu-devel@nongnu.org; Wed, 09 Nov 2016 22:42:51 -0500 Date: Thu, 10 Nov 2016 13:46:54 +1100 From: David Gibson Message-ID: <20161110024654.GF18060@umbus.fritz.box> References: <20161110020617.GE18060@umbus.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RE3pQJLXZi4fr8Xo" Content-Disposition: inline In-Reply-To: <20161110020617.GE18060@umbus.fritz.box> Subject: Re: [Qemu-devel] [TRIVIAL][RFC][PATCH] FU exceptions should carry a cause (IC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Balbir Singh Cc: qemu-ppc@nongnu.org, Cedric Le Goater , qemu-devel@nongnu.org --RE3pQJLXZi4fr8Xo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 10, 2016 at 01:06:17PM +1100, David Gibson wrote: > On Thu, Nov 10, 2016 at 12:42:37PM +1100, Balbir Singh wrote: > >=20 > >=20 > > As per the ISA we need a cause for FU exceptions.Executing a tabort r9 > > for example in libc, causes a EXCP_FU exception. We don't wire up the > > IC (cause) when we post the exception. The cause is required > > for the kernel to do the right thing. I caught this issue while testing > > the latest kernel against Cedrics' latest pnv ipmi branch. > >=20 > > Signed-off-by: Balbir singh >=20 > Applied to ppc-for-2.8 Or not.. This causes compile breakage for the ppc32 targets. >=20 > > --- > > target-ppc/excp_helper.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c > > index 808760b..cccea8d 100644 > > --- a/target-ppc/excp_helper.c > > +++ b/target-ppc/excp_helper.c > > @@ -427,6 +427,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, in= t excp_model, int excp) > > case POWERPC_EXCP_VPU: /* Vector unavailable exception = */ > > case POWERPC_EXCP_VSXU: /* VSX unavailable exception = */ > > case POWERPC_EXCP_FU: /* Facility unavailable exception = */ > > + env->spr[SPR_FSCR] |=3D ((target_ulong)env->error_code << 56); > > break; > > case POWERPC_EXCP_PIT: /* Programmable interval timer interr= upt */ > > LOG_EXCP("PIT exception\n"); >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --RE3pQJLXZi4fr8Xo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYI9+cAAoJEGw4ysog2bOS0SUQAJM5nGaVNaJGgXDSisr7RfVh 19D1WNirL4B/+S1m6gvUIW19yk5Yl4lUuEGcCAOQ51fQC4+Hal3GSkF3LOKT8nUz 06Es4oBpL/ZEIygo0mm9iP4Hpu/rLuhUZTH/SE2Swe6WQFM7dAAncg++mH8wVvxw U5euJct9xFg81gFVPg4lekPr5I3caOg2qt0quxz5fXnws/1G9KJQmMZrLZDSA7dr w5AMcsOGTf3hGCCUZH2si6WHiq2/zOlIZ0L9fIp9is4llm1AD5P3ValJVH1WSOHe aR9pLBLEfxbU3wjlfPywboIkp92E9Xmedqda0fWnqt+ZxrEe9GZxLoN8WSry8hMk wo1B4k+bLHdapksMh2UJltkZPjDWIcqkOrIO4B42abak7D4gdkuN8SsH4aGgT5Dr mALFdF31fD/bEqQLIsdc4rppVE3O9LhyhPSK06llu/9toPMcsM+/vCiZlAU0Xz1c j9h5wZqE5HGiiiqbI1X/V6f2xXN62/gGVkDwrx36Bsd8Vk3lZzxu64MMFEdpoF0C BPLoePfPpsAgwN3JNE1fPd/QTejW82OdKqahN441L2IoOi3qV29PpDcOE6tWUesN wjEs6eJazSRgZy43RxLYBvbrFGgGauWyipuz8QWmatPQq62ED7DKnfz+LTKYD7aw uUMyFM7ZiqMfUpZWeAe3 =tHMl -----END PGP SIGNATURE----- --RE3pQJLXZi4fr8Xo--