From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1c4gCx-0006j1-2J
	for qemu-devel@nongnu.org; Wed, 09 Nov 2016 22:39:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1c4gCs-0007wB-7e
	for qemu-devel@nongnu.org; Wed, 09 Nov 2016 22:39:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54020)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <famz@redhat.com>) id 1c4gCs-0007uj-21
	for qemu-devel@nongnu.org; Wed, 09 Nov 2016 22:39:18 -0500
Date: Thu, 10 Nov 2016 11:39:14 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20161110033914.GE8422@lemon>
References: <CAFEAcA8ff=cEz-MrWFAFm2=8zWkJy=cbRpErQEBkwigaoVm67g@mail.gmail.com>
	<20161107133045.GM5036@stefanha-x1.localdomain>
	<bf3151dc-1236-c738-c473-d427996713e4@redhat.com>
	<20161108162044.GE11274@stefanha-x1.localdomain>
	<e0354262-92dc-de5b-b3b1-94e4eb462396@redhat.com>
	<20161109113226.GD4682@stefanha-x1.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161109113226.GD4682@stefanha-x1.localdomain>
Subject: Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format
 question)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: John Snow <jsnow@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Wed, 11/09 11:32, Stefan Hajnoczi wrote:
> No doc comments -> error.

I'm not sure that is a good idea. For example all .bdrv_co_flush_to_disk
implementations have the same semantics and signature, requiring doc comments
everywhere might be too much.

Fam