qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] test-uuid: fix leak
@ 2016-11-09 11:02 Marc-André Lureau
  2016-11-09 20:46 ` John Snow
  2016-11-10  8:40 ` Fam Zheng
  0 siblings, 2 replies; 3+ messages in thread
From: Marc-André Lureau @ 2016-11-09 11:02 UTC (permalink / raw)
  To: qemu-devel; +Cc: famz, Marc-André Lureau

ASAN spotted:
SUMMARY: AddressSanitizer: 74 byte(s) leaked in 2 allocation(s).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/test-uuid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/test-uuid.c b/tests/test-uuid.c
index 77dcdc4..d3a2791 100644
--- a/tests/test-uuid.c
+++ b/tests/test-uuid.c
@@ -161,6 +161,7 @@ static void test_uuid_unparse_strdup(void)
         }
         out = qemu_uuid_unparse_strdup(&uuid_test_data[i].uuid);
         g_assert_cmpstr(uuid_test_data[i].uuidstr, ==, out);
+        g_free(out);
     }
 }
 
-- 
2.10.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] test-uuid: fix leak
  2016-11-09 11:02 [Qemu-devel] [PATCH] test-uuid: fix leak Marc-André Lureau
@ 2016-11-09 20:46 ` John Snow
  2016-11-10  8:40 ` Fam Zheng
  1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2016-11-09 20:46 UTC (permalink / raw)
  To: Marc-André Lureau, qemu-devel; +Cc: famz



On 11/09/2016 06:02 AM, Marc-André Lureau wrote:
> ASAN spotted:
> SUMMARY: AddressSanitizer: 74 byte(s) leaked in 2 allocation(s).
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/test-uuid.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/test-uuid.c b/tests/test-uuid.c
> index 77dcdc4..d3a2791 100644
> --- a/tests/test-uuid.c
> +++ b/tests/test-uuid.c
> @@ -161,6 +161,7 @@ static void test_uuid_unparse_strdup(void)
>          }
>          out = qemu_uuid_unparse_strdup(&uuid_test_data[i].uuid);
>          g_assert_cmpstr(uuid_test_data[i].uuidstr, ==, out);
> +        g_free(out);
>      }
>  }
>
>

Reviewed-by: John Snow <jsnow@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] test-uuid: fix leak
  2016-11-09 11:02 [Qemu-devel] [PATCH] test-uuid: fix leak Marc-André Lureau
  2016-11-09 20:46 ` John Snow
@ 2016-11-10  8:40 ` Fam Zheng
  1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2016-11-10  8:40 UTC (permalink / raw)
  To: Marc-André Lureau; +Cc: qemu-devel

On Wed, 11/09 15:02, Marc-André Lureau wrote:
> ASAN spotted:
> SUMMARY: AddressSanitizer: 74 byte(s) leaked in 2 allocation(s).
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/test-uuid.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/test-uuid.c b/tests/test-uuid.c
> index 77dcdc4..d3a2791 100644
> --- a/tests/test-uuid.c
> +++ b/tests/test-uuid.c
> @@ -161,6 +161,7 @@ static void test_uuid_unparse_strdup(void)
>          }
>          out = qemu_uuid_unparse_strdup(&uuid_test_data[i].uuid);
>          g_assert_cmpstr(uuid_test_data[i].uuidstr, ==, out);
> +        g_free(out);
>      }
>  }
>  
> -- 
> 2.10.0
> 

Thanks, applied:

https://github.com/famz/qemu/tree/staging

Fam

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-10  8:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-09 11:02 [Qemu-devel] [PATCH] test-uuid: fix leak Marc-André Lureau
2016-11-09 20:46 ` John Snow
2016-11-10  8:40 ` Fam Zheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).