From: Kevin O'Connor <kevin@koconnor.net>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
mst@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
Jeff Fan <jeff.fan@intel.com>
Subject: Re: [Qemu-devel] FW_CFG_NB_CPUS vs fwcfg file 'etc/boot-cpus'
Date: Fri, 11 Nov 2016 09:44:03 -0500 [thread overview]
Message-ID: <20161111144403.GA15857@morn.lan> (raw)
In-Reply-To: <20161111153619.3ef19ccb@nial.brq.redhat.com>
On Fri, Nov 11, 2016 at 03:36:19PM +0100, Igor Mammedov wrote:
> On Fri, 11 Nov 2016 15:02:36 +0100
> Laszlo Ersek <lersek@redhat.com> wrote:
>
> > adding Jeff Fan and Jordan Justen
> >
> > On 11/11/16 13:57, Igor Mammedov wrote:
> > > While looking at OVMF and how it handles CPUs (ACPI/AP wakeup),
> > > I've noticed that it uses legacy FW_CFG_NB_CPUS(0x05) to get
> > > the number of present at start CPUs.
> >
> > Where exactly do you see this?
> That's the only place in OVMF, but according to google there are
> other firmwares that use FW_CFG_NB_CPUS so we are not free to remove
> it and break guests.
>
> So I'd just drop not yet released 'etc/boot-cpus',
> of cause SeaBIOS should be fixed and its blob in QEMU updated.
I have no preference between FW_CFG_NB_CPUS and 'etc/boot-cpus'. Note
that SeaBIOS v1.10 was released with the code using 'etc/boot-cpus'
though. If it's to go away, we'll need a SeaBIOS stable branch
release with the change.
-Kevin
next prev parent reply other threads:[~2016-11-11 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 12:57 [Qemu-devel] FW_CFG_NB_CPUS vs fwcfg file 'etc/boot-cpus' Igor Mammedov
2016-11-11 14:02 ` Laszlo Ersek
2016-11-11 14:36 ` Igor Mammedov
2016-11-11 14:44 ` Kevin O'Connor [this message]
2016-11-11 15:05 ` Igor Mammedov
2016-11-11 16:37 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111144403.GA15857@morn.lan \
--to=kevin@koconnor.net \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jeff.fan@intel.com \
--cc=jordan.l.justen@intel.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).