From: Samuel Thibault <samuel.thibault@gnu.org>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory
Date: Mon, 14 Nov 2016 00:17:20 +0100 [thread overview]
Message-ID: <20161113231720.GW18437@var.home> (raw)
In-Reply-To: <147907882660.226.11346739841651262168@9040ca97f87d>
Hello,
Note:
no-reply@patchew.org, on Sun 13 Nov 2016 15:13:47 -0800, wrote:
> Your series seems to have some coding style problems. See output below for
> more information:
>
> === OUTPUT BEGIN ===
> fatal: unrecognized argument: --no-patch
> Checking PATCH 1/1: ...
> ERROR: suspect code indent for conditional statements (4, 6)
> #29: FILE: slirp/socket.c:74:
> + if (ifm->ifq_so == so) {
> + ifm->ifq_so = NULL;
>
> ERROR: suspect code indent for conditional statements (4, 6)
> #37: FILE: slirp/socket.c:82:
> + if (ifm->ifq_so == so) {
> + ifm->ifq_so = NULL;
This is due to that portion of the slirp code using 2-space indentation
instead of 4-space indentation.
Samuel
next prev parent reply other threads:[~2016-11-13 23:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 23:01 [Qemu-devel] [PATCH] slirp: Fix access to freed memory Samuel Thibault
2016-11-13 23:13 ` no-reply
2016-11-13 23:17 ` Samuel Thibault [this message]
2016-11-14 16:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113231720.GW18437@var.home \
--to=samuel.thibault@gnu.org \
--cc=famz@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).