From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44163)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1c641f-0005ni-N5
	for qemu-devel@nongnu.org; Sun, 13 Nov 2016 18:17:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1c641e-0002gd-PG
	for qemu-devel@nongnu.org; Sun, 13 Nov 2016 18:17:27 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:43553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1c641e-0002gK-IU
	for qemu-devel@nongnu.org; Sun, 13 Nov 2016 18:17:26 -0500
Date: Mon, 14 Nov 2016 00:17:20 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20161113231720.GW18437@var.home>
References: <20161113230102.12173-1-samuel.thibault@ens-lyon.org>
	<147907882660.226.11346739841651262168@9040ca97f87d>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <147907882660.226.11346739841651262168@9040ca97f87d>
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, jan.kiszka@siemens.com

Hello,

Note:

no-reply@patchew.org, on Sun 13 Nov 2016 15:13:47 -0800, wrote:
> Your series seems to have some coding style problems. See output below for
> more information:
> 
> === OUTPUT BEGIN ===
> fatal: unrecognized argument: --no-patch
> Checking PATCH 1/1: ...
> ERROR: suspect code indent for conditional statements (4, 6)
> #29: FILE: slirp/socket.c:74:
> +    if (ifm->ifq_so == so) {
> +      ifm->ifq_so = NULL;
> 
> ERROR: suspect code indent for conditional statements (4, 6)
> #37: FILE: slirp/socket.c:82:
> +    if (ifm->ifq_so == so) {
> +      ifm->ifq_so = NULL;

This is due to that portion of the slirp code using 2-space indentation
instead of 4-space indentation.

Samuel