From: Stefan Hajnoczi <stefanha@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: qemu-devel@nongnu.org, jan.kiszka@siemens.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory
Date: Mon, 14 Nov 2016 16:28:10 +0000 [thread overview]
Message-ID: <20161114162810.GE26664@stefanha-x1.localdomain> (raw)
In-Reply-To: <20161113230102.12173-1-samuel.thibault@ens-lyon.org>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Mon, Nov 14, 2016 at 12:01:02AM +0100, Samuel Thibault wrote:
> if_start() goes through the slirp->if_fastq and slirp->if_batchq
> list of pending messages, and accesses ifm->ifq_so->so_nqueued of its
> elements if ifm->ifq_so != NULL. When freeing a socket, we thus need
> to make sure that any pending message for this socket does not refer
> to the socket any more.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Tested-by: Brian Candler <b.candler@pobox.com>
> ---
> slirp/socket.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Please send a slirp pull request for QEMU 2.8-rc0 (deadline November
15th) or -rc1 (deadline November 22nd).
CCing qemu-stable.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-11-14 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 23:01 [Qemu-devel] [PATCH] slirp: Fix access to freed memory Samuel Thibault
2016-11-13 23:13 ` no-reply
2016-11-13 23:17 ` Samuel Thibault
2016-11-14 16:28 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114162810.GE26664@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).