From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6apM-00085U-BU for qemu-devel@nongnu.org; Tue, 15 Nov 2016 05:18:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6apJ-0006Ot-87 for qemu-devel@nongnu.org; Tue, 15 Nov 2016 05:18:56 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:35088) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6apJ-0006Of-1I for qemu-devel@nongnu.org; Tue, 15 Nov 2016 05:18:53 -0500 Received: by mail-wm0-x241.google.com with SMTP id a20so24208271wme.2 for ; Tue, 15 Nov 2016 02:18:52 -0800 (PST) Date: Tue, 15 Nov 2016 10:18:50 +0000 From: Stefan Hajnoczi Message-ID: <20161115101850.GA4836@stefanha-x1.localdomain> References: <1478566785-4002-1-git-send-email-ashish.mittal@veritas.com> <1478566785-4002-2-git-send-email-ashish.mittal@veritas.com> <20161114150701.GD26198@stefanha-x1.localdomain> <20161114154906.GC2373@lemon> <20161114165034.GA1352@stefanha-x1.localdomain> <20161114180359.GA24217@lemon> <20161115020405.GB9226@lemon> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20161115020405.GB9226@lemon> Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Eric Blake , kwolf@redhat.com, Venkatesha.Mg@veritas.com, ashish.mittal@veritas.com, jcody@redhat.com, qemu-devel@nongnu.org, Rakesh.Ranjan@veritas.com, armbru@redhat.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, pbonzini@redhat.com, Buddhi.Madhav@veritas.com, Ashish Mittal --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 15, 2016 at 10:04:05AM +0800, Fam Zheng wrote: > On Mon, 11/14 13:06, Eric Blake wrote: > > So I guess you have to determine if libqnio is something that should > > compile completely independent from qemu, or whether it is so closely > > tied to the rest of qemu that it should follow qemu conventions. >=20 > The question is on include directives in block/vxhs.c, not libnqio library > header, so qemu conventions apply. Eric: The libqnio library header is not copied into the QEMU source tree. It is an external library dependency like libnfs or libglfs. Fam, Markus: Unfortunately neither the clean-includes script nor its patch series cover letter explains *why* osdep.h should be included before system headers. The libqnio header is self-contained (i.e. you can #include it and it has no dependencies) and only used by vxhs.c. Why is it a good idea to include qemu/osdep.h first? Seems like a bad idea to me because it masks missing dependencies in the libqnio header. Stefan --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYKuEKAAoJEJykq7OBq3PIk5IIAKdiOyvAuSDztRM1aQ+OCmpT bkcoSPIKOhZ9paZ043FdFkqSWQVuP+3BO0Rt396uoqi9dY7hsBti26FEub5Wa7V1 IKihI5jkk/IYhFsd/uBLGjDvfzTEIaQpND3yXKJoIDU+eWEQHq9teA51BOvyLAdd I4oO/c00x1wmI6R5/VOpnnjiGY5YnzxZc+SIMZKAANkAz9AhWFvcF7qdbbmQsk1w 4PqpobwFfgxn/kK9313Y9TZqV5f+OMxDw1IdzS+nETq1eu4P0vsDqa0eNubbOzTU yFe9o8rTysq+hLLDfzXw1AJH8YYAK9WpWQRkXJtGSV1PQwd9H+aEqU4mgBz967s= =Amsy -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--