From: Alex Williamson <alex.williamson@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Daniel Oram <daniel.oram@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/1] Fix assert in PCI address property when used by vfio-pci
Date: Tue, 15 Nov 2016 11:23:23 -0700 [thread overview]
Message-ID: <20161115112323.34b9ddeb@t450s.home> (raw)
In-Reply-To: <20161115180152.GC25480@thinpad.lan.raisama.net>
On Tue, 15 Nov 2016 16:01:52 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Thu, Nov 10, 2016 at 12:42:07PM +0000, Daniel Oram wrote:
> > Allow the PCIHostDeviceAddress structure to work as the host property
> > in vfio-pci when it has it's default value of all fields set to ~0. In
> > this form the property indicates a non-existant device but given the
> > field bit sizes gets asserted as excess (and invalid) precision
> > overflows the string buffer. The BDF of an invalid device
> > "FFFF:FF:FF.F" is returned instead.
> >
> > Signed-off-by: Daniel Oram <daniel.oram@gmail.com>
> > Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
>
> Applied to machine-next after removing trailing-spaces detected
> by checkpatch.pl. Thanks.
Thanks for grabbing this, Eduardo.
Alex
next prev parent reply other threads:[~2016-11-15 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 12:42 [Qemu-devel] [PATCH v2 0/1] vfio-pci: fix assert fail in host property if unused Daniel Oram
2016-11-10 12:42 ` [Qemu-devel] [PATCH v2 1/1] Fix assert in PCI address property when used by vfio-pci Daniel Oram
2016-11-15 18:01 ` Eduardo Habkost
2016-11-15 18:23 ` Alex Williamson [this message]
2016-11-13 3:17 ` [Qemu-devel] [PATCH v2 0/1] vfio-pci: fix assert fail in host property if unused no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115112323.34b9ddeb@t450s.home \
--to=alex.williamson@redhat.com \
--cc=daniel.oram@gmail.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).