From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6iOF-0001D2-HO for qemu-devel@nongnu.org; Tue, 15 Nov 2016 13:23:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6iOD-0003Ek-Gg for qemu-devel@nongnu.org; Tue, 15 Nov 2016 13:23:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38322) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6iOD-0003Ea-Am for qemu-devel@nongnu.org; Tue, 15 Nov 2016 13:23:25 -0500 Date: Tue, 15 Nov 2016 11:23:23 -0700 From: Alex Williamson Message-ID: <20161115112323.34b9ddeb@t450s.home> In-Reply-To: <20161115180152.GC25480@thinpad.lan.raisama.net> References: <71f06765c4ba16dcd71cbf78e877619948f04ed9.1478777270.git.daniel.oram@gmail.com> <20161115180152.GC25480@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] Fix assert in PCI address property when used by vfio-pci List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Daniel Oram , qemu-devel@nongnu.org On Tue, 15 Nov 2016 16:01:52 -0200 Eduardo Habkost wrote: > On Thu, Nov 10, 2016 at 12:42:07PM +0000, Daniel Oram wrote: > > Allow the PCIHostDeviceAddress structure to work as the host property > > in vfio-pci when it has it's default value of all fields set to ~0. In > > this form the property indicates a non-existant device but given the > > field bit sizes gets asserted as excess (and invalid) precision > > overflows the string buffer. The BDF of an invalid device > > "FFFF:FF:FF.F" is returned instead. > > > > Signed-off-by: Daniel Oram > > Reviewed-by: Alex Williamson > > Applied to machine-next after removing trailing-spaces detected > by checkpatch.pl. Thanks. Thanks for grabbing this, Eduardo. Alex