From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6i3U-00020I-Mt for qemu-devel@nongnu.org; Tue, 15 Nov 2016 13:02:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6i3P-0002mv-8y for qemu-devel@nongnu.org; Tue, 15 Nov 2016 13:02:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33258) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6i3P-0002mT-45 for qemu-devel@nongnu.org; Tue, 15 Nov 2016 13:01:55 -0500 Date: Tue, 15 Nov 2016 16:01:52 -0200 From: Eduardo Habkost Message-ID: <20161115180152.GC25480@thinpad.lan.raisama.net> References: <71f06765c4ba16dcd71cbf78e877619948f04ed9.1478777270.git.daniel.oram@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71f06765c4ba16dcd71cbf78e877619948f04ed9.1478777270.git.daniel.oram@gmail.com> Subject: Re: [Qemu-devel] [PATCH v2 1/1] Fix assert in PCI address property when used by vfio-pci List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel Oram Cc: qemu-devel@nongnu.org, alex.williamson@redhat.com On Thu, Nov 10, 2016 at 12:42:07PM +0000, Daniel Oram wrote: > Allow the PCIHostDeviceAddress structure to work as the host property > in vfio-pci when it has it's default value of all fields set to ~0. In > this form the property indicates a non-existant device but given the > field bit sizes gets asserted as excess (and invalid) precision > overflows the string buffer. The BDF of an invalid device > "FFFF:FF:FF.F" is returned instead. > > Signed-off-by: Daniel Oram > Reviewed-by: Alex Williamson Applied to machine-next after removing trailing-spaces detected by checkpatch.pl. Thanks. -- Eduardo