From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1c6wq5-0002a9-FV
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 04:49:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1c6wq0-0003er-KP
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 04:49:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46778)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <famz@redhat.com>) id 1c6wq0-0003dg-FE
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 04:49:04 -0500
Date: Wed, 16 Nov 2016 17:49:01 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20161116094901.GA31999@lemon>
References: <20161114180359.GA24217@lemon>
	<ff56438b-d75f-eb5a-c398-9ce1b20c2f40@redhat.com>
	<20161115020405.GB9226@lemon>
	<20161115101850.GA4836@stefanha-x1.localdomain>
	<20161115124417.GC9226@lemon>
	<20161115144551.GB17672@stefanha-x1.localdomain>
	<20161115150016.GD9226@lemon>
	<20161115192026.GA26428@stefanha-x1.localdomain>
	<CAAo6VWN9uO9-jjEfHxLHCBE5V5tr5Sx52tGY5vu3g8JgcCRqvQ@mail.gmail.com>
	<87eg2bokx0.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87eg2bokx0.fsf@dusky.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new
 block device type called "vxhs"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: ashish mittal <ashmit602@gmail.com>, Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Venkatesha.Mg@veritas.com, Ashish Mittal <ashish.mittal@veritas.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jeff Cody <jcody@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Rakesh Ranjan <Rakesh.Ranjan@veritas.com>, Ketan Nilangekar <Ketan.Nilangekar@veritas.com>, Abhijit Dey <Abhijit.Dey@veritas.com>, Paolo Bonzini <pbonzini@redhat.com>, Buddhi.Madhav@veritas.com

On Wed, 11/16 10:04, Markus Armbruster wrote:
> ashish mittal <ashmit602@gmail.com> writes:
> 
> > Thanks for concluding on this.
> >
> > I will rearrange the qnio_api.h header accordingly as follows:
> >
> > +#include "qemu/osdep.h"
> 
> Headers should not include osdep.h.

This is about including "osdep.h" _and_ "qnio_api.h" in block/vxhs.c, so what
Ashish means looks good to me.

Fam

> 
> > +#include <qnio/qnio_api.h>   <=== after osdep.h
> > +#include "block/block_int.h"
> 
> Including block_int.h in a header is problematic.  Are you sure you need
> it?  Will qnio/qnio_api.h ever be included outside block/?
> 
> > +#include "qapi/qmp/qerror.h"
> > +#include "qapi/qmp/qdict.h"
> > +#include "qapi/qmp/qstring.h"
> > +#include "trace.h"
> > +#include "qemu/uri.h"
> > +#include "qapi/error.h"
> > +#include "qemu/error-report.h"  <==== remove
> 
> In general, headers should include what they need, but no more.
>