From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42605)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1c7A4w-0000oL-JT
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 18:57:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1c7A4s-0004HE-4F
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 18:57:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58146)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <alex.williamson@redhat.com>)
	id 1c7A4r-0004Gu-Uw
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 18:57:18 -0500
Date: Wed, 16 Nov 2016 16:57:15 -0700
From: Alex Williamson <alex.williamson@redhat.com>
Message-ID: <20161116165715.5da8f734@t450s.home>
In-Reply-To: <1479329194-10247-11-git-send-email-kwankhede@nvidia.com>
References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com>
	<1479329194-10247-11-git-send-email-kwankhede@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v14 10/22] vfio iommu type1: Add support
 for mediated devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kirti Wankhede <kwankhede@nvidia.com>
Cc: pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, jike.song@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org

On Thu, 17 Nov 2016 02:16:22 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:
> @@ -931,6 +1344,24 @@ static void vfio_iommu_type1_detach_group(void *iommu_data,
>  
>  	mutex_lock(&iommu->lock);
>  
> +	if (iommu->external_domain) {
> +		group = find_iommu_group(iommu->external_domain, iommu_group);
> +		if (group) {
> +			list_del(&group->next);
> +			kfree(group);
> +
> +			if (list_empty(&iommu->external_domain->group_list)) {
> +				vfio_sanity_check_pfn_list(iommu);
> +
> +				if (!IS_IOMMU_CAP_DOMAIN_IN_CONTAINER(iommu))
> +					vfio_iommu_unmap_unpin_all(iommu);
> +
> +				kfree(iommu->external_domain);

I advised in one place that I didn't understand why  we were checking
iommu->external_domain before walking the pfn_list, but we do have
several checks still in place for if(iommu->external_domain), so I
think we better be setting to NULL after we free it.

I haven't finished my review yet, but if this ends up being the only
comment and you agree, I can add:

iommu->external_domain = NULL;

here on commit.  Thanks,

Alex