From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1c7A9Z-0002Pc-9O
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 19:02:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1c7A9W-00073x-95
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 19:02:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48796)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <alex.williamson@redhat.com>)
	id 1c7A9W-00073e-3l
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 19:02:06 -0500
Date: Wed, 16 Nov 2016 17:02:03 -0700
From: Alex Williamson <alex.williamson@redhat.com>
Message-ID: <20161116170203.7bc6ff86@t450s.home>
In-Reply-To: <1479329194-10247-12-git-send-email-kwankhede@nvidia.com>
References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com>
	<1479329194-10247-12-git-send-email-kwankhede@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v14 11/22] vfio iommu: Add blocking
 notifier to notify DMA_UNMAP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kirti Wankhede <kwankhede@nvidia.com>
Cc: pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, jike.song@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org

On Thu, 17 Nov 2016 02:16:23 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:
> @@ -1321,12 +1350,11 @@ static void vfio_iommu_unmap_unpin_reaccount(struct vfio_iommu *iommu)
>  
>  static void vfio_sanity_check_pfn_list(struct vfio_iommu *iommu)
>  {
> -	struct rb_node *n, *p;
> +	struct rb_node *n;
>  
>  	n = rb_first(&iommu->dma_list);
>  	for (; n; n = rb_next(n)) {
>  		struct vfio_dma *dma;
> -		int unlocked = 0;
>  
>  		dma = rb_entry(n, struct vfio_dma, node);
>  

This chunk really should have been part of 10/22 as well.