From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7PKz-0001sB-15 for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:14:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7PKx-0002t6-QM for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:14:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44618) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7PKx-0002sr-KU for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:14:55 -0500 Date: Thu, 17 Nov 2016 09:14:53 -0700 From: Alex Williamson Message-ID: <20161117091453.6e9de7c2@t450s.home> In-Reply-To: <27bfa26c-4d57-7f64-a489-f3d341d00fea@nvidia.com> References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com> <1479329194-10247-13-git-send-email-kwankhede@nvidia.com> <582DA41A.7010204@intel.com> <20161117082737.7f6ff329@t450s.home> <27bfa26c-4d57-7f64-a489-f3d341d00fea@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirti Wankhede Cc: Jike Song , pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org On Thu, 17 Nov 2016 21:30:26 +0530 Kirti Wankhede wrote: > On 11/17/2016 8:57 PM, Alex Williamson wrote: > > On Thu, 17 Nov 2016 20:35:38 +0800 > > Jike Song wrote: > > > >> On 11/17/2016 04:46 AM, Kirti Wankhede wrote: > >>> Add a notifier calback to parent's ops structure of mdev device so that per > >>> device notifer for vfio module is registered through vfio_mdev module. > >>> > >>> Signed-off-by: Kirti Wankhede > >>> Signed-off-by: Neo Jia > >>> Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637 > >>> --- > >>> drivers/vfio/mdev/vfio_mdev.c | 34 +++++++++++++++++++++++++++++++++- > >>> include/linux/mdev.h | 9 +++++++++ > >>> 2 files changed, 42 insertions(+), 1 deletion(-) > >>> > >> > >> Hi Alex, Kirti, > >> > >> Since everyone agreed we should let the vendor driver call vfio_register_notifier > >> directly, can you drop this patch from merging? So that I don't need to send a > >> reverse patch. > > > > This seems like a reasonable request to me, this patch drops cleanly > > from the series. Any objection Kirti? It seems like it removes a > > little bit of pre-release churn from the API. Thanks, > > > > This is independent patch, I don't have any concern to drop this patch. > > Small nit: Since Documentation patch is later in series, its mentioned > in the doc. One line need to be removed from vfio-mediated-device.txt. > > --- a/Documentation/vfio-mediated-device.txt > +++ b/Documentation/vfio-mediated-device.txt > @@ -150,7 +150,6 @@ The callbacks in the parent_ops structure are as > follows: > * read : read emulation callback > * write: write emulation callback > * mmap: mmap emulation callback > -* notifier: notifier callback Good catch, I'll remove this line. Thanks, Alex