From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1c7I6U-0008Fi-Sz
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 03:31:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1c7I6P-00087O-5i
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 03:31:30 -0500
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37733
	helo=mx0a-001b2d01.pphosted.com)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <cornelia.huck@de.ibm.com>)
	id 1c7I6P-00086a-0e
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 03:31:25 -0500
Received: from pps.filterd (m0098420.ppops.net [127.0.0.1])
	by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id
	uAH8TGaZ140564
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2016 03:31:23 -0500
Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])
	by mx0b-001b2d01.pphosted.com with ESMTP id 26s5fcrhap-1
	(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2016 03:31:23 -0500
Received: from localhost
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Thu, 17 Nov 2016 08:31:21 -0000
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 02ED217D805D
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2016 08:33:45 +0000 (GMT)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id uAH8VKjb25886838
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2016 08:31:20 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id uAH8VJAr003818
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2016 03:31:20 -0500
Date: Thu, 17 Nov 2016 09:31:18 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
In-Reply-To: <1479333189-20082-2-git-send-email-stefanha@redhat.com>
References: <1479333189-20082-1-git-send-email-stefanha@redhat.com>
	<1479333189-20082-2-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20161117093118.798b49ea.cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>, zhunxun@gmail.com, Fam Zheng <famz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>

On Wed, 16 Nov 2016 21:53:07 +0000
Stefan Hajnoczi <stefanha@redhat.com> wrote:

> virtio_queue_notify_vq() checks vdev->broken before invoking the
> handler, virtio_queue_notify_aio_vq() should too.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/virtio/virtio.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>

I think this makes sense as a fix independent of your other patches.