From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7K1O-0005Bi-Oe for qemu-devel@nongnu.org; Thu, 17 Nov 2016 05:34:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7K1J-0003zP-Oq for qemu-devel@nongnu.org; Thu, 17 Nov 2016 05:34:22 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:33857) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7K1J-0003z5-IL for qemu-devel@nongnu.org; Thu, 17 Nov 2016 05:34:17 -0500 Received: by mail-wm0-x242.google.com with SMTP id g23so19932127wme.1 for ; Thu, 17 Nov 2016 02:34:17 -0800 (PST) Date: Thu, 17 Nov 2016 10:34:14 +0000 From: Stefan Hajnoczi Message-ID: <20161117103414.GC24138@stefanha-x1.localdomain> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9Ek0hoCL9XbhcSqy" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] a small issue with VSOCK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Imbrenda Cc: Stefan Hajnoczi , marius vlad , "Michael S. Tsirkin" , Ian Campbell , qemu-devel@nongnu.org, Alex =?iso-8859-1?Q?Benn=E9e?= , Christoffer Dall , Greg Kurz --9Ek0hoCL9XbhcSqy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 15, 2016 at 07:25:59PM +0100, Claudio Imbrenda wrote: > I have found a small issue in the current implementation of VSOCK: if > you load both the vhost_vsock module (or if it's compiled in) then the > vmw_vsock_virtio_transport will not load successfully (both when > compiled as a module or compiled in). >=20 > The actual error message I get is: >=20 > vmw_vsock_virtio_transport: probe of virtio2 failed with error -16 >=20 > I dug into the code and it seems that vsock_core_init is called twice, > once for the vhost module and once for the virtio-transport module, the > second time returning -EBUSY (-16) since it's already initialized. >=20 > This means that if a guest loads the vhost_vsock module, or if it is > compiled in, then the guest can't use virtio-vsock. This also prevents > using vsock in a nested virtualization scenario, where both host and > guest modules could work at the same time. >=20 > Unfortunately I don't have the time to fix this, I just wanted to raise > the issue here, so that you are now aware of it, and can maybe fix it in > the future. Thanks for letting me know. It's definitely something that will need to be fixed. I've added it to my todo list. Stefan --9Ek0hoCL9XbhcSqy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYLYemAAoJEJykq7OBq3PIf0wIAMbLNq9mPQmmByesCR0bmR2u 3jtXUmQltg9xq0ejBBivc0ZcD4d6XqeuIm+Ld5/vbY4q5oHzDvvjPhFdbX3AdRSR vqbCGE4Oddli/ldkaCs1Ao8FktaK2Ux6j14HITPnW6yw6B5ba8GholixPNDA/vWs xwtIrXomNkvIMdW1JJgMj5XPJWKkUfZCc8455AQDe2CJ7hwhOfI7rgJOieIgZcWD ETxboGN9evbokZ3eE9TbexIwrgEOtY3VZ+9yHN4/eggzOAEfBwCBtgynnr+/ruUa gjEVPJHODCaHNPWm9jG1w1TR5gwyla4LNE9h7mGMJd+dD85Ocu03a1OwIzmBPwc= =Ty1X -----END PGP SIGNATURE----- --9Ek0hoCL9XbhcSqy--