From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7gps-0004GK-N8 for qemu-devel@nongnu.org; Fri, 18 Nov 2016 05:56:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7gpr-000447-UG for qemu-devel@nongnu.org; Fri, 18 Nov 2016 05:56:00 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:33785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7gpr-00042M-NH for qemu-devel@nongnu.org; Fri, 18 Nov 2016 05:55:59 -0500 Received: by mail-wm0-x242.google.com with SMTP id u144so4942216wmu.0 for ; Fri, 18 Nov 2016 02:55:59 -0800 (PST) Date: Fri, 18 Nov 2016 10:55:56 +0000 From: Stefan Hajnoczi Message-ID: <20161118105556.GD28853@stefanha-x1.localdomain> References: <1479333189-20082-1-git-send-email-stefanha@redhat.com> <1479333189-20082-2-git-send-email-stefanha@redhat.com> <20161117093118.798b49ea.cornelia.huck@de.ibm.com> <20161117105830.GH24138@stefanha-x1.localdomain> <20161117132447.71885d6b.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WChQLJJJfbwij+9x" Content-Disposition: inline In-Reply-To: <20161117132447.71885d6b.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: add missing vdev->broken check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Stefan Hajnoczi , Kevin Wolf , zhunxun@gmail.com, Fam Zheng , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Christian Borntraeger , Paolo Bonzini --WChQLJJJfbwij+9x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 17, 2016 at 01:24:47PM +0100, Cornelia Huck wrote: > On Thu, 17 Nov 2016 10:58:30 +0000 > Stefan Hajnoczi wrote: >=20 > > On Thu, Nov 17, 2016 at 09:31:18AM +0100, Cornelia Huck wrote: > > > On Wed, 16 Nov 2016 21:53:07 +0000 > > > Stefan Hajnoczi wrote: > > >=20 > > > > virtio_queue_notify_vq() checks vdev->broken before invoking the > > > > handler, virtio_queue_notify_aio_vq() should too. > > > >=20 > > > > Signed-off-by: Stefan Hajnoczi > > > > --- > > > > hw/virtio/virtio.c | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > >=20 > > > Reviewed-by: Cornelia Huck > > >=20 > > > I think this makes sense as a fix independent of your other patches. > >=20 > > I'm not aware of an actual bug caused by this. virtio_queue_pop() > > returns NULL when the device is broken. > >=20 > > This is more for consistency than correctness, so I didn't add > > qemu-stable, -rc1, or send it as a separate fix. >=20 > Fair enough. It was more "we should add this patch even if we don't use > the other patches in this series". Okay. Stefan --WChQLJJJfbwij+9x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYLt48AAoJEJykq7OBq3PIfXIH/1E62Gi3qmYnioiDm4QaXYda HhWldDbC4dmQr4n5UisOh72gkqxnzcoQJxG0Xf+3LFHYsJFkUYVMfKOGaGjZF2aO vJ/bXNcg36/jBvt88jtdoV13HWX/nGT24CmlgiuN23glAq2bqwBafNulheaxqHwU /+pn+oN0LVjbhV8KR4rQPLYxuCMnoNTuNQum2UpZ8Ry42CTdYzsqyhuY57UdA1w3 yL3AnqwpCNNU3MaR2aoH62iTdtlpecD6Y2AqNx3mKk3e5KlG0KOQD1hnv/IyLt7H 92YuU0o0/3kDRKq5cwcjkRrSyXVYIWNbnnaTGfN/nzouqUQXwg6zvFD7puebkwo= =mLgS -----END PGP SIGNATURE----- --WChQLJJJfbwij+9x--