From: Stefan Hajnoczi <stefanha@gmail.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] trace: fix generated code build break
Date: Fri, 18 Nov 2016 11:10:20 +0000 [thread overview]
Message-ID: <20161118111020.GH28853@stefanha-x1.localdomain> (raw)
In-Reply-To: <147939115373.23044.3882265154149942210.stgit@bahia>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Thu, Nov 17, 2016 at 02:59:13PM +0100, Greg Kurz wrote:
> If the QEMU source dir is
>
> /var/tmp/aaa-qemu-clone
>
> and the build dir is
>
> /var/tmp/qemu-aio-poll-v2
>
> Then I get an error as:
>
> trace/generated-tracers.c:15950:13: error: invalid suffix "_trace_events"
> on integer constant
> TraceEvent *2_trace_events[] = {
> ^
> trace/generated-tracers.c:15950:13: error: expected identifier or ‘(’ before
> numeric constant
> trace/generated-tracers.c: In function ‘trace_2_register_events’:
> trace/generated-tracers.c:17949:32: error: invalid suffix "_trace_events" on
> integer constant
> trace_event_register_group(2_trace_events);
> ^
> make: *** [trace/generated-tracers.o] Error 1
>
> This patch fixes the issue.
>
> Reported-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> scripts/tracetool.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-11-18 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 13:59 [Qemu-devel] [PATCH] trace: fix generated code build break Greg Kurz
2016-11-17 14:22 ` Fam Zheng
2016-11-17 14:25 ` Daniel P. Berrange
2016-11-17 14:44 ` Greg Kurz
2016-11-18 11:10 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118111020.GH28853@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).