From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7h3r-0006dI-VW for qemu-devel@nongnu.org; Fri, 18 Nov 2016 06:10:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7h3n-0004RL-Vy for qemu-devel@nongnu.org; Fri, 18 Nov 2016 06:10:27 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36144) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7h3n-0004QI-OY for qemu-devel@nongnu.org; Fri, 18 Nov 2016 06:10:23 -0500 Received: by mail-wm0-x243.google.com with SMTP id m203so5009681wma.3 for ; Fri, 18 Nov 2016 03:10:23 -0800 (PST) Date: Fri, 18 Nov 2016 11:10:20 +0000 From: Stefan Hajnoczi Message-ID: <20161118111020.GH28853@stefanha-x1.localdomain> References: <147939115373.23044.3882265154149942210.stgit@bahia> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KscVNZbUup0vZz0f" Content-Disposition: inline In-Reply-To: <147939115373.23044.3882265154149942210.stgit@bahia> Subject: Re: [Qemu-devel] [PATCH] trace: fix generated code build break List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: qemu-devel@nongnu.org, Fam Zheng , Stefan Hajnoczi --KscVNZbUup0vZz0f Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 17, 2016 at 02:59:13PM +0100, Greg Kurz wrote: > If the QEMU source dir is >=20 > /var/tmp/aaa-qemu-clone >=20 > and the build dir is >=20 > /var/tmp/qemu-aio-poll-v2 >=20 > Then I get an error as: >=20 > trace/generated-tracers.c:15950:13: error: invalid suffix "_trace_events" > on integer constant > TraceEvent *2_trace_events[] =3D { > ^ > trace/generated-tracers.c:15950:13: error: expected identifier or =E2=80= =98(=E2=80=99 before > numeric constant > trace/generated-tracers.c: In function =E2=80=98trace_2_register_events= =E2=80=99: > trace/generated-tracers.c:17949:32: error: invalid suffix "_trace_events"= on > integer constant > trace_event_register_group(2_trace_events); > ^ > make: *** [trace/generated-tracers.o] Error 1 >=20 > This patch fixes the issue. >=20 > Reported-by: Fam Zheng > Signed-off-by: Greg Kurz > --- > scripts/tracetool.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan --KscVNZbUup0vZz0f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYLuGcAAoJEJykq7OBq3PI1rsH/27PAfQDxgoazeMMG3EItm1n /PVAHOBFe4XUwcWZjsoxlzRpyon+4ykaBDkQXDcMMZpFbPaL9+LlCXlPJ1S0m70u LIFLuJPqUKcAX+tHGL6a33/SllOnRCYf0miN8AD9aUlJIh/wNvnpRBGHVacNP++N HGkggKOyCmyAyuUkrhtyTVXDH4+XsKLaOdlM6BP55V8w9yVS8Qt2M/M+IMcgYVn+ ZnT9EDXBDUGaEvx8Uheg/7g6JPKRn9dcMzP5tcgtLWqFsK4qgO1dvZkVdqhnpdP1 DD4zQjGPB8MreesOuNg5dlkgryFkq3dABxUSBBNc0pDQWWOvQFUl3jIf+PK+3vQ= =e1BL -----END PGP SIGNATURE----- --KscVNZbUup0vZz0f--