From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7jsH-0000D6-Fa for qemu-devel@nongnu.org; Fri, 18 Nov 2016 09:10:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7jsC-00023n-Ep for qemu-devel@nongnu.org; Fri, 18 Nov 2016 09:10:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51144) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7jsC-00023b-8I for qemu-devel@nongnu.org; Fri, 18 Nov 2016 09:10:36 -0500 Date: Fri, 18 Nov 2016 16:10:34 +0200 From: "Michael S. Tsirkin" Message-ID: <20161118160812-mutt-send-email-mst@kernel.org> References: <20161118103659.10448-1-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161118103659.10448-1-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu devel list , Kevin O'Connor , Gerd Hoffmann , Paolo Bonzini On Fri, Nov 18, 2016 at 11:36:56AM +0100, Laszlo Ersek wrote: > This is v3 of the series, with updates based on the v2 discussion: > . > > I've added feature negotiation via the APM_STS ("scratchpad") register. > A new spec file called "docs/specs/q35-apm-sts.txt" is included. > > Tested with new OVMF patches (about to send out those as well). > Regression tested with SeaBIOS (beyond simple functional tests with > maximum SeaBIOS logging enabled, I used gdb to step through the new > ich9_apm_status_changed() callback to see if it was behaving compatibly > with SeaBIOS). > > The series was developed and tested on top of v2.7.0, because v2.8.0-rc0 > crashes very quickly for me when running OVMF: > > kvm_io_ioeventfd_add: error adding ioeventfd: File exists > > It is my understanding that there are patches on the list for this: > > [Qemu-devel] [PATCH v2 for-2.8 0/3] virtio fixes > > Anyway, the series rebases to v2.8.0-rc0 without as much as context > differences. > > Cc: "Kevin O'Connor" > Cc: "Michael S. Tsirkin" > Cc: Gerd Hoffmann > Cc: Paolo Bonzini I'll review. Pls remember it will have to be re-posted or pinged after 2.8 is out. > Thanks > Laszlo > > Laszlo Ersek (3): > hw/isa/apm: introduce callback for APM_STS_IOPORT writes > hw/isa/lpc_ich9: add SMI feature negotiation via APM_STS > hw/isa/lpc_ich9: ICH9_APM_STS_F_BROADCAST_SMI: inject SMI on all VCPUs > > docs/specs/q35-apm-sts.txt | 80 ++++++++++++++++++++++++++++++++++++++++++++++ > include/hw/i386/ich9.h | 9 ++++++ > include/hw/isa/apm.h | 9 +++--- > hw/acpi/piix4.c | 2 +- > hw/isa/apm.c | 15 ++++++--- > hw/isa/lpc_ich9.c | 64 +++++++++++++++++++++++++++++++++++-- > hw/isa/vt82c686.c | 2 +- > 7 files changed, 168 insertions(+), 13 deletions(-) > create mode 100644 docs/specs/q35-apm-sts.txt > > -- > 2.9.2