From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7nKf-0006aa-IE for qemu-devel@nongnu.org; Fri, 18 Nov 2016 12:52:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7nKc-00063u-Ff for qemu-devel@nongnu.org; Fri, 18 Nov 2016 12:52:13 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:54491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7nKc-00063B-8n for qemu-devel@nongnu.org; Fri, 18 Nov 2016 12:52:10 -0500 Date: Fri, 18 Nov 2016 18:52:08 +0100 From: Samuel Thibault Message-ID: <20161118175208.GC3422@var.home> References: <20161117122000.22577-1-Vincent.Bernat@exoscale.ch> <8737iqxpmf.fsf@luffy.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8737iqxpmf.fsf@luffy.cx> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent Bernat Cc: Jan Kiszka , qemu-devel@nongnu.org Hello, Vincent Bernat, on Thu 17 Nov 2016 13:22:32 +0100, wrote: > =E2=9D=A6 17 novembre 2016 13:20 +0100, Vincent Bernat =C2=A0: >=20 > > Some network equipments are requesting a file using the netascii > > protocol and this is not configurable. Currently, qemu's tftpd only > > supports the octet protocol. This commit makes it accept the netascii > > protocol as well but do not perform the requested transformation (LF = -> > > CR,LF) as it would be far more complex. The current implementation is > > good enough. A user has always the choice to preencode the served fil= e > > correctly. >=20 > Signed-off-by: Vincent Bernat Thanks, I've pushed to my tree and requested a pull. Samuel