From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9BYL-0006g7-Cs for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:56:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9BYH-0003dz-HW for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:56:05 -0500 Received: from 2.mo6.mail-out.ovh.net ([46.105.76.65]:56129) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9BYH-0003cZ-Bm for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:56:01 -0500 Received: from player761.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id E28DB5FF11 for ; Tue, 22 Nov 2016 14:55:58 +0100 (CET) Date: Tue, 22 Nov 2016 14:55:47 +0100 From: Greg Kurz Message-ID: <20161122145547.0549ae27@bahia> In-Reply-To: References: <147981681351.30309.4854065801791462661.stgit@bahia.lab.toulouse-stg.fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Markus Armbruster , Pradeep Kiruvale , Max Reitz On Tue, 22 Nov 2016 14:51:12 +0100 Alberto Garcia wrote: > On Tue 22 Nov 2016 01:49:51 PM CET, Greg Kurz wrote: > > > This will allow other subsystems (i.e. fsdev) to implement throttling > > without duplicating the command line options. > > > > Signed-off-by: Greg Kurz > > Did you check if it's possible / easy to do defining a normal array > instead of a macro and using qemu_opts_append() or something similar? > > Berto No I didn't due to lack of time but maybe Pradeep may have a look in this direction ? Cheers. -- Greg