From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Oud-000689-86 for qemu-devel@nongnu.org; Tue, 22 Nov 2016 23:12:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9Oub-0000X5-Vi for qemu-devel@nongnu.org; Tue, 22 Nov 2016 23:11:59 -0500 Date: Wed, 23 Nov 2016 15:06:50 +1100 From: David Gibson Message-ID: <20161123040650.GB17795@umbus.fritz.box> References: <1479815165-31059-1-git-send-email-nikunj@linux.vnet.ibm.com> <1479815165-31059-5-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cmJC7u66zC7hs+87" Content-Disposition: inline In-Reply-To: <1479815165-31059-5-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 4/9] target-ppc: Add xscmpoqp and xscmpuqp instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com --cmJC7u66zC7hs+87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 22, 2016 at 05:16:00PM +0530, Nikunj A Dadhania wrote: > From: Bharata B Rao >=20 > xscmpoqp - VSX Scalar Compare Ordered Quad-Precision > xscmpuqp - VSX Scalar Compare Unordered Quad-Precision >=20 > Signed-off-by: Bharata B Rao > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/fpu_helper.c | 52 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/helper.h | 2 ++ > target-ppc/translate/vsx-impl.inc.c | 2 ++ > target-ppc/translate/vsx-ops.inc.c | 2 ++ > 4 files changed, 58 insertions(+) >=20 > diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c > index b1c5a07..28c1fea 100644 > --- a/target-ppc/fpu_helper.c > +++ b/target-ppc/fpu_helper.c > @@ -2518,6 +2518,58 @@ void helper_##op(CPUPPCState *env, uint32_t opcode= ) \ > VSX_SCALAR_CMP(xscmpodp, 1) > VSX_SCALAR_CMP(xscmpudp, 0) > =20 > +#define VSX_SCALAR_CMPQ(op, ordered) \ > +void helper_##op(CPUPPCState *env, uint32_t opcode) \ > +{ \ > + ppc_vsr_t xa, xb; \ > + uint32_t cc =3D 0; = \ > + bool vxsnan_flag =3D false, vxvc_flag =3D false; = \ > + float128 a, b; \ > + \ > + helper_reset_fpstatus(env); \ > + getVSR(rA(opcode) + 32, &xa, env); \ > + getVSR(rB(opcode) + 32, &xb, env); \ > + \ > + a =3D make_float128(xa.VsrD(0), xa.VsrD(1)); = \ > + b =3D make_float128(xb.VsrD(0), xb.VsrD(1)); = \ > + \ > + if (float128_is_signaling_nan(a, &env->fp_status) || \ > + float128_is_signaling_nan(b, &env->fp_status)) { \ > + vxsnan_flag =3D true; = \ > + cc =3D 1; = \ > + if (fpscr_ve =3D=3D 0 && ordered) { = \ > + vxvc_flag =3D true; = \ > + } \ > + } else if (ordered && (float128_is_quiet_nan(a, &env->fp_status) \ > + || float128_is_quiet_nan(b, &env->fp_status))= ) { \ > + cc =3D 1; = \ Please use symbolic constants for the CC bits. > + vxvc_flag =3D true; = \ > + } \ > + if (vxsnan_flag) { \ > + float_invalid_op_excp(env, POWERPC_EXCP_FP_VXSNAN, 0); \ > + } \ > + if (vxvc_flag) { \ > + float_invalid_op_excp(env, POWERPC_EXCP_FP_VXVC, 0); \ > + } \ > + \ > + if (float128_lt(a, b, &env->fp_status)) { \ > + cc |=3D 8; = \ > + } else if (!float128_le(a, b, &env->fp_status)) { \ > + cc |=3D 4; = \ > + } else { \ > + cc |=3D 2; = \ > + } \ > + \ > + env->fpscr &=3D ~(0x0F << FPSCR_FPRF); = \ > + env->fpscr |=3D cc << FPSCR_FPRF; = \ > + env->crf[BF(opcode)] =3D cc; = \ > + \ > + float_check_status(env); \ > +} > + > +VSX_SCALAR_CMPQ(xscmpoqp, 1) > +VSX_SCALAR_CMPQ(xscmpuqp, 0) > + > /* VSX_MAX_MIN - VSX floating point maximum/minimum > * name - instruction mnemonic > * op - operation (max or min) > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index ba42015..3b26678 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -408,6 +408,8 @@ DEF_HELPER_2(xscmpexpdp, void, env, i32) > DEF_HELPER_2(xscmpexpqp, void, env, i32) > DEF_HELPER_2(xscmpodp, void, env, i32) > DEF_HELPER_2(xscmpudp, void, env, i32) > +DEF_HELPER_2(xscmpoqp, void, env, i32) > +DEF_HELPER_2(xscmpuqp, void, env, i32) > DEF_HELPER_2(xsmaxdp, void, env, i32) > DEF_HELPER_2(xsmindp, void, env, i32) > DEF_HELPER_2(xscvdpsp, void, env, i32) > diff --git a/target-ppc/translate/vsx-impl.inc.c b/target-ppc/translate/v= sx-impl.inc.c > index 5206258..ed9588e 100644 > --- a/target-ppc/translate/vsx-impl.inc.c > +++ b/target-ppc/translate/vsx-impl.inc.c > @@ -628,6 +628,8 @@ GEN_VSX_HELPER_2(xscmpexpdp, 0x0C, 0x07, 0, PPC2_ISA3= 00) > GEN_VSX_HELPER_2(xscmpexpqp, 0x04, 0x05, 0, PPC2_ISA300) > GEN_VSX_HELPER_2(xscmpodp, 0x0C, 0x05, 0, PPC2_VSX) > GEN_VSX_HELPER_2(xscmpudp, 0x0C, 0x04, 0, PPC2_VSX) > +GEN_VSX_HELPER_2(xscmpoqp, 0x04, 0x04, 0, PPC2_VSX) > +GEN_VSX_HELPER_2(xscmpuqp, 0x04, 0x14, 0, PPC2_VSX) > GEN_VSX_HELPER_2(xsmaxdp, 0x00, 0x14, 0, PPC2_VSX) > GEN_VSX_HELPER_2(xsmindp, 0x00, 0x15, 0, PPC2_VSX) > GEN_VSX_HELPER_2(xscvdpsp, 0x12, 0x10, 0, PPC2_VSX) > diff --git a/target-ppc/translate/vsx-ops.inc.c b/target-ppc/translate/vs= x-ops.inc.c > index 2468ee9..7f09527 100644 > --- a/target-ppc/translate/vsx-ops.inc.c > +++ b/target-ppc/translate/vsx-ops.inc.c > @@ -126,6 +126,8 @@ GEN_XX3FORM(xscmpexpdp, 0x0C, 0x07, PPC2_ISA300), > GEN_VSX_XFORM_300(xscmpexpqp, 0x04, 0x05, 0x00600001), > GEN_XX2IFORM(xscmpodp, 0x0C, 0x05, PPC2_VSX), > GEN_XX2IFORM(xscmpudp, 0x0C, 0x04, PPC2_VSX), > +GEN_VSX_XFORM_300(xscmpoqp, 0x04, 0x04, 0x00600001), > +GEN_VSX_XFORM_300(xscmpuqp, 0x04, 0x14, 0x00600001), > GEN_XX3FORM(xsmaxdp, 0x00, 0x14, PPC2_VSX), > GEN_XX3FORM(xsmindp, 0x00, 0x15, PPC2_VSX), > GEN_XX2FORM(xscvdpsp, 0x12, 0x10, PPC2_VSX), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --cmJC7u66zC7hs+87 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYNRXaAAoJEGw4ysog2bOSad4P+wbWXVE+07eSV8Qzqo6gjcEg koc0umG/cf8L/9Uh2NEukWld/kuQaQ0LDzqrB6gyxIMOo+51jAeQsV/Bt+xjoYAU lUqeSvy2hMfetTfob9vLhNTO5DbdnY4GLOXePi/j6E3ujuFkbKlNfopXP7xzpRJu zvdEfu36lZwmuh4x7YJL2rKOVWNCobyvWmK9Ic0Z1H7jogmUTRdRJpssvwU1Pfx3 gU5KLgJBtGYQ0qFIvOfJ6I1t9MAgV6ssaJ4RBvP+S8jAbnbnGkp8Vcs6UUTLtZyV HWC0UymQ26asnh77sIpU4UgbLdtvPvBGibPMaKkwJq8SS/20DoEPDEfpEqJQLD9k GoBSHcfYxC7bCeDgw9iAp54nLpEvPiD0qslE9GvUlVkZLY/rkWMMtNYLetkR7oZD IhjvxSHt70WsP7/eJfKpT9VhXlXjtG3iFH1OX9E+OjCgpjxmQLRdj+4Kcq6jznSj hz257H5pRCFu3clVNt2tlCc272P2rlaCLgdC84UiRFANHV2OzEHYZZ2g5a0Rq5PI n81cU2UM46PPxDGNxAp1a66PvohHQkgGANNDsjmOQITCB682YbuANi9p93Q5UxyQ sA/Pe2yrXbVYCeso05MkKjq0miLv0Y/XcRUfYHcqDplyAILEVeIWIfTcei483hcs HxRZGaBgaLPrf2nXSrgc =KYFT -----END PGP SIGNATURE----- --cmJC7u66zC7hs+87--