From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1c9WR6-0001XB-6x
	for qemu-devel@nongnu.org; Wed, 23 Nov 2016 07:14:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1c9WR1-0007cP-8u
	for qemu-devel@nongnu.org; Wed, 23 Nov 2016 07:14:00 -0500
Received: from 3.mo3.mail-out.ovh.net ([46.105.44.175]:54327)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <groug@kaod.org>) id 1c9WR1-0007bY-20
	for qemu-devel@nongnu.org; Wed, 23 Nov 2016 07:13:55 -0500
Received: from player730.ha.ovh.net (b7.ovh.net [213.186.33.57])
	by mo3.mail-out.ovh.net (Postfix) with ESMTP id 267EB61129
	for <qemu-devel@nongnu.org>; Wed, 23 Nov 2016 13:13:52 +0100 (CET)
Date: Wed, 23 Nov 2016 13:13:43 +0100
From: Greg Kurz <groug@kaod.org>
Message-ID: <20161123131343.5b047061@bahia>
In-Reply-To: <CAJ2SuLmWg29m07ynVMNi2DrnChGpdDwtUknhDb1NKrRMVUeQJA@mail.gmail.com>
References: <147981681351.30309.4854065801791462661.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
	<w51twazlj1r.fsf@maestria.local.igalia.com>
	<20161122145547.0549ae27@bahia>
	<CAJ2SuLmWg29m07ynVMNi2DrnChGpdDwtUknhDb1NKrRMVUeQJA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline
 options to a separate header file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pradeep Kiruvale <pradeepkiruvale@gmail.com>
Cc: Alberto Garcia <berto@igalia.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>

On Tue, 22 Nov 2016 16:02:12 +0100
Pradeep Kiruvale <pradeepkiruvale@gmail.com> wrote:

> On 22 November 2016 at 14:55, Greg Kurz <groug@kaod.org> wrote:
> 
> > On Tue, 22 Nov 2016 14:51:12 +0100
> > Alberto Garcia <berto@igalia.com> wrote:
> >
> > > On Tue 22 Nov 2016 01:49:51 PM CET, Greg Kurz wrote:
> > >
> > > > This will allow other subsystems (i.e. fsdev) to implement throttling
> > > > without duplicating the command line options.
> > > >
> > > > Signed-off-by: Greg Kurz <groug@kaod.org>
> > >
> > > Did you check if it's possible / easy to do defining a normal array
> > > instead of a macro and using qemu_opts_append() or something similar?
> > >
> > > Berto
> >
> > No I didn't due to lack of time but maybe Pradeep may have a look in this
> > direction ?
> >
> 
> Only may be next year :)
> 

Ok, and also, it will be the occasion to add the throttling options to
the legacy -virtfs command line option as well.

Cheers.

--
Greg

> -Pradeep
> 
> 
> >
> > Cheers.
> >
> > --
> > Greg
> >