From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9iqJ-0001R9-KC for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9iqH-0005am-Tc for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:51 -0500 Date: Thu, 24 Nov 2016 12:24:10 +1100 From: David Gibson Message-ID: <20161124012410.GN17795@umbus.fritz.box> References: <1479918105-15616-1-git-send-email-joserz@linux.vnet.ibm.com> <1479918105-15616-3-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QGBKWVSgmlsIyJ+t" Content-Disposition: inline In-Reply-To: <1479918105-15616-3-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 2/4] target-ppc: Implement bcdctsq. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --QGBKWVSgmlsIyJ+t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 23, 2016 at 02:21:43PM -0200, Jose Ricardo Ziviani wrote: > bcdctsq.: Decimal convert to signed quadword. It is possible to > convert packed decimal values to signed quadwords. >=20 > Signed-off-by: Jose Ricardo Ziviani Reviewed-by: David Gibson > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 40 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 7 +++++++ > 3 files changed, 48 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 87f533c..503f257 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -383,6 +383,7 @@ DEF_HELPER_3(bcdctn, i32, avr, avr, i32) > DEF_HELPER_3(bcdcfz, i32, avr, avr, i32) > DEF_HELPER_3(bcdctz, i32, avr, avr, i32) > DEF_HELPER_3(bcdcfsq, i32, avr, avr, i32) > +DEF_HELPER_3(bcdctsq, i32, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 751909c..ca0d0b8 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2919,6 +2919,46 @@ uint32_t helper_bcdcfsq(ppc_avr_t *r, ppc_avr_t *b= , uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdctsq(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps) > +{ > + uint8_t i; > + int cr; > + uint64_t carry; > + uint64_t unused; > + uint64_t lo_value; > + uint64_t hi_value =3D 0; > + int sgnb =3D bcd_get_sgn(b); > + int invalid =3D (sgnb =3D=3D 0); > + > + lo_value =3D bcd_get_digit(b, 31, &invalid); > + for (i =3D 30; i > 0; i--) { > + mulu64(&lo_value, &carry, lo_value, 10ULL); > + mulu64(&hi_value, &unused, hi_value, 10ULL); > + lo_value +=3D bcd_get_digit(b, i, &invalid); > + hi_value +=3D carry; > + > + if (unlikely(invalid)) { > + break; > + } > + } > + > + if (sgnb =3D=3D -1) { > + r->s64[LO_IDX] =3D -lo_value; > + r->s64[HI_IDX] =3D ~hi_value + !r->s64[LO_IDX]; > + } else { > + r->s64[LO_IDX] =3D lo_value; > + r->s64[HI_IDX] =3D hi_value; > + } > + > + cr =3D bcd_cmp_zero(b); > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 36141e5..1579b58 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -990,10 +990,14 @@ GEN_BCD2(bcdctn) > GEN_BCD2(bcdcfz) > GEN_BCD2(bcdctz) > GEN_BCD2(bcdcfsq) > +GEN_BCD2(bcdctsq) > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > switch (opc4(ctx->opcode)) { > + case 0: > + gen_bcdctsq(ctx); > + break; > case 2: > gen_bcdcfsq(ctx); > break; > @@ -1018,6 +1022,9 @@ static void gen_xpnd04_1(DisasContext *ctx) > static void gen_xpnd04_2(DisasContext *ctx) > { > switch (opc4(ctx->opcode)) { > + case 0: > + gen_bcdctsq(ctx); > + break; > case 2: > gen_bcdcfsq(ctx); > break; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --QGBKWVSgmlsIyJ+t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYNkE6AAoJEGw4ysog2bOSaHYP/2lXx0E1lgfb/GUaZOp6PxLI cSFIzK+RRhMqRmeTB7NmZ/ZQc9FPct+xPy/EM/CMdnj1YAvxjIuoi7LybZCfgWRL g2gKzOkBHCk66iAyWJvqVEjoDAHaKHRvXCkfb/bwonwjo/G2QvP2nY9AgRBbL7mP A2fipVu4woQYew/m2eCJVbXQZznzicVhB0JvMzlfTXc/16RivTRnm10Pcs/7ndoj 2ZZ/j6wJt+Jh6KGCua3AxmJGF8kzKuQNgoEuMHt6yHTZAezw8GShV+UgVi9UUN2c UvW2nPVBqHop6KbgH8MZKMDQY9s4smE0jBTPThCC8HxyD4JbxWpq1hCKyW5Hg4gR 2P8arSyJIaEl9bV8WzdVhdLMfI30PyB0zU4yrYugb/1AqOXJeuVDSAxM1WUj+LP0 aSytekbAUnKeMUYmZ0MC/5Xr/jGsnk7/zVEOseMHKg/OcyH+2AOi1jHUa8ttH7JZ tZsxWio0+ugRERZKE1SaD0IOWe2nT0sfsABe075rhzQLrCOogFW8NoaNr0dK+46S RavlV+Q/Mess1XQO4TyCns7yv3TPdlbplfAJBtHgvCLMHmovkEbP2qazHKEmcVv8 PwCyv/b2Lwd56fbBmuXV658sVRdLfWNmwDsv4MiUg2O+SAy9ZXeDYEWIUoKLz4Wu XSba3FU/lk2NwZr7EL9X =9mdu -----END PGP SIGNATURE----- --QGBKWVSgmlsIyJ+t--