From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9iqI-0001QL-He for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9iqG-0005Wz-Gy for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:50 -0500 Date: Thu, 24 Nov 2016 12:26:42 +1100 From: David Gibson Message-ID: <20161124012642.GO17795@umbus.fritz.box> References: <1479918105-15616-1-git-send-email-joserz@linux.vnet.ibm.com> <1479918105-15616-4-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Y5wfsVCgeKAcINk2" Content-Disposition: inline In-Reply-To: <1479918105-15616-4-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 3/4] target-ppc: Implement bcdcpsgn. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --Y5wfsVCgeKAcINk2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 23, 2016 at 02:21:44PM -0200, Jose Ricardo Ziviani wrote: > bcdcpsgn.: Decimal copy sign. Given two registers vra and vrb, it > copies the vra value with vrb sign to the result register vrt. >=20 > Signed-off-by: Jose Ricardo Ziviani Reviewed-by: David Gibson > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 23 +++++++++++++++++++++++ > target-ppc/translate/vmx-impl.inc.c | 3 +++ > target-ppc/translate/vmx-ops.inc.c | 2 +- > 4 files changed, 28 insertions(+), 1 deletion(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 503f257..dada48e 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -384,6 +384,7 @@ DEF_HELPER_3(bcdcfz, i32, avr, avr, i32) > DEF_HELPER_3(bcdctz, i32, avr, avr, i32) > DEF_HELPER_3(bcdcfsq, i32, avr, avr, i32) > DEF_HELPER_3(bcdctsq, i32, avr, avr, i32) > +DEF_HELPER_4(bcdcpsgn, i32, avr, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index ca0d0b8..833c9d2 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2959,6 +2959,29 @@ uint32_t helper_bcdctsq(ppc_avr_t *r, ppc_avr_t *b= , uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdcpsgn(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, uint3= 2_t ps) > +{ > + int i; > + int invalid =3D 0; > + > + if (bcd_get_sgn(a) =3D=3D 0 || bcd_get_sgn(b) =3D=3D 0) { > + return 1 << CRF_SO; > + } > + > + *r =3D *a; > + bcd_put_digit(r, b->u8[BCD_DIG_BYTE(0)] & 0xF, 0); > + > + for (i =3D 1; i < 32; i++) { > + bcd_get_digit(a, i, &invalid); > + bcd_get_digit(b, i, &invalid); > + if (unlikely(invalid)) { > + return 1 << CRF_SO; > + } > + } > + > + return bcd_cmp_zero(r); > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 1579b58..c14b666 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -991,6 +991,7 @@ GEN_BCD2(bcdcfz) > GEN_BCD2(bcdctz) > GEN_BCD2(bcdcfsq) > GEN_BCD2(bcdctsq) > +GEN_BCD(bcdcpsgn); > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > @@ -1056,6 +1057,8 @@ GEN_VXFORM_DUAL(vsubuhm, PPC_ALTIVEC, PPC_NONE, \ > bcdsub, PPC_NONE, PPC2_ALTIVEC_207) > GEN_VXFORM_DUAL(vsubuhs, PPC_ALTIVEC, PPC_NONE, \ > bcdsub, PPC_NONE, PPC2_ALTIVEC_207) > +GEN_VXFORM_DUAL(vaddshs, PPC_ALTIVEC, PPC_NONE, \ > + bcdcpsgn, PPC_NONE, PPC2_ISA300) > =20 > static void gen_vsbox(DisasContext *ctx) > { > diff --git a/target-ppc/translate/vmx-ops.inc.c b/target-ppc/translate/vm= x-ops.inc.c > index f02b3be..70d7d2b 100644 > --- a/target-ppc/translate/vmx-ops.inc.c > +++ b/target-ppc/translate/vmx-ops.inc.c > @@ -131,7 +131,7 @@ GEN_VXFORM_DUAL(vaddubs, vmul10uq, 0, 8, PPC_ALTIVEC,= PPC_NONE), > GEN_VXFORM_DUAL(vadduhs, vmul10euq, 0, 9, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM(vadduws, 0, 10), > GEN_VXFORM(vaddsbs, 0, 12), > -GEN_VXFORM(vaddshs, 0, 13), > +GEN_VXFORM_DUAL(vaddshs, bcdcpsgn, 0, 13, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM(vaddsws, 0, 14), > GEN_VXFORM_DUAL(vsububs, bcdadd, 0, 24, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM_DUAL(vsubuhs, bcdsub, 0, 25, PPC_ALTIVEC, PPC_NONE), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Y5wfsVCgeKAcINk2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYNkHSAAoJEGw4ysog2bOSxdAQANDVHVxilochBhSe3XzL7mQR r4qjtawtgHKnOVIXbogKm3zbNZ4g+F2pAVgIjPKDppoS1FQu+q4ljNd0qIvgMB7G R1llW/jFE75rp31D/nd/0CMc5WZ+lsgQQZjD6KASjDobQcL/GncYAP+1aj4oK2BG z8ICAj3VnTxwpyKYlYaeXEEB6GUXhgC+Z7wO0jMB2YyOdtoPNS8lLk4BXNpOAqrH SCrYBjModgo3cmPUvwwJ7JrlEOAUkPHv0H/HfOpv5mAQQetn+MSylYG6CweGazRO ZVKrlcUS2qJYrFTEuC65rS8cD6mz4bAS6FPUVdeZ4E1O0KNSbql7E8luzMtf4FHX MYTBBLVDZGsSqgrm9+2Mi60lyWHQ4KiERIe/DVnBJ5LV0quwid1CWm5kt1mpulqF otzrbSxDz/RvUKF46LyX6IcX1cSVbsCIbQkg4TiY/PDfeBfvcUSTYwlSVsSmDj2M qR5TajOAauMA2hUjp0K3f1T8Li+QsgoDvkNfCzY8mJJ9f5lF/hllHURswQKMvzl7 eIO0ROCrc80+Pn5cGk0ttymXApQHS9OwtdZKvZpfw/HkHDIseEjEuBFve7ENG+Y7 rdmRh8QjE1UzCbULAS1Ud4adJpSe/a18JUb0m4iM/HGen80hhfedbQVn255j1cUX Lo+BFYVCvOc0WpXcaNu5 =DD6Y -----END PGP SIGNATURE----- --Y5wfsVCgeKAcINk2--