From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9iqH-0001Pn-Sn for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9iqD-0005Qd-LG for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:49 -0500 Date: Thu, 24 Nov 2016 12:27:41 +1100 From: David Gibson Message-ID: <20161124012741.GP17795@umbus.fritz.box> References: <1479918105-15616-1-git-send-email-joserz@linux.vnet.ibm.com> <1479918105-15616-5-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XFI+TFG+M3u0jUjZ" Content-Disposition: inline In-Reply-To: <1479918105-15616-5-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 4/4] target-ppc: Implement bcdsetsgn. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --XFI+TFG+M3u0jUjZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 23, 2016 at 02:21:45PM -0200, Jose Ricardo Ziviani wrote: > bcdsetsgn.: Decimal set sign. This instruction copies the register > value to the result register but adjust the signal according to > the preferred sign value. >=20 > Signed-off-by: Jose Ricardo Ziviani Reviewed-by: David Gibson > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 19 +++++++++++++++++++ > target-ppc/translate/vmx-impl.inc.c | 8 ++++++++ > 3 files changed, 28 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index dada48e..cddac8e 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -385,6 +385,7 @@ DEF_HELPER_3(bcdctz, i32, avr, avr, i32) > DEF_HELPER_3(bcdcfsq, i32, avr, avr, i32) > DEF_HELPER_3(bcdctsq, i32, avr, avr, i32) > DEF_HELPER_4(bcdcpsgn, i32, avr, avr, avr, i32) > +DEF_HELPER_3(bcdsetsgn, i32, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 833c9d2..db430ef 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2982,6 +2982,25 @@ uint32_t helper_bcdcpsgn(ppc_avr_t *r, ppc_avr_t *= a, ppc_avr_t *b, uint32_t ps) > return bcd_cmp_zero(r); > } > =20 > +uint32_t helper_bcdsetsgn(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps) > +{ > + int i; > + int invalid =3D 0; > + int sgnb =3D bcd_get_sgn(b); > + > + *r =3D *b; > + bcd_put_digit(r, bcd_preferred_sgn(sgnb, ps), 0); > + > + for (i =3D 1; i < 32; i++) { > + bcd_get_digit(b, i, &invalid); > + if (unlikely(invalid)) { > + return 1 << CRF_SO; > + } > + } > + > + return bcd_cmp_zero(r); > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index c14b666..b188e60 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -991,6 +991,7 @@ GEN_BCD2(bcdcfz) > GEN_BCD2(bcdctz) > GEN_BCD2(bcdcfsq) > GEN_BCD2(bcdctsq) > +GEN_BCD2(bcdsetsgn) > GEN_BCD(bcdcpsgn); > =20 > static void gen_xpnd04_1(DisasContext *ctx) > @@ -1014,6 +1015,9 @@ static void gen_xpnd04_1(DisasContext *ctx) > case 7: > gen_bcdcfn(ctx); > break; > + case 31: > + gen_bcdsetsgn(ctx); > + break; > default: > gen_invalid(ctx); > break; > @@ -1038,12 +1042,16 @@ static void gen_xpnd04_2(DisasContext *ctx) > case 7: > gen_bcdcfn(ctx); > break; > + case 31: > + gen_bcdsetsgn(ctx); > + break; > default: > gen_invalid(ctx); > break; > } > } > =20 > + > GEN_VXFORM_DUAL(vsubcuw, PPC_ALTIVEC, PPC_NONE, \ > xpnd04_1, PPC_NONE, PPC2_ISA300) > GEN_VXFORM_DUAL(vsubsws, PPC_ALTIVEC, PPC_NONE, \ --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --XFI+TFG+M3u0jUjZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYNkINAAoJEGw4ysog2bOSMq4QAItzKEHbugSrTnc0qwkn1TwC /GPJtAx4EdhkAM0nsvHUkhBiLVhERcAXNJd4vAp8ZrDcZiHLbSOmJSD6mhwSqYLe 4NloAiYXwt/tLLClhPHiQnzPkges+6nh85lQM934vW0GERmzXNUtoN6APYxJ/BYV bD3er3Ll5bbJdrOUDhKs6HJ0vce/78kkOjs6DMDFO049iwUiwywCjtW1ygE+dRiB Znox6VwNadZhu/RNzN89w+xr2XEUAIwcyWLdkAzePoPiZJi8R6kJDk28533Y1sy1 EJhT+N2C2p83x+0ncbiV9W6Kx0zzg8VLax5hjorHgVje8xzl2K3Zay/tTDYl57+L ePCwnWWORtcEIebTxRW3ZhjU54mJpJKrUcJEXdW8AIjW5YZ1bwwNtUAP31mpgdQH s/O/WwfRMVF1WbFNxi6MwMWQXujbIpiYfUHKvqpon1W1ZaC28DFfIREe4caG68Vl 1cSCWWZREJbYfVhvwakOo6QxIq9Lks7HqfOssve55yaZvCef1pFCnARxOdxzPKow gE9jyNAvoOYZ88mP2t/5n4jKoJXp63YJAQ9MEK0iri/yYfxJW/5qn49eE5TTSuZC D7hPCO4nB4YTPzvkFW9IjbD/yX0auKspbtN6G08KTCD2OlV8Rdnd1oWFxaRadqRl LudQW4ZtQ7Pfm0mSWBbE =ty/S -----END PGP SIGNATURE----- --XFI+TFG+M3u0jUjZ--