From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9iqJ-0001Qd-0Z for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9iqH-0005ZP-H1 for qemu-devel@nongnu.org; Wed, 23 Nov 2016 20:28:51 -0500 Date: Thu, 24 Nov 2016 12:28:32 +1100 From: David Gibson Message-ID: <20161124012832.GQ17795@umbus.fritz.box> References: <1479918105-15616-1-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yPSgZSQ6mfPWgZ9n" Content-Disposition: inline In-Reply-To: <1479918105-15616-1-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 0/4] POWER9 TCG enablements - BCD functions part II List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --yPSgZSQ6mfPWgZ9n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 23, 2016 at 02:21:41PM -0200, Jose Ricardo Ziviani wrote: > v2: > - use div128 and mul64 functions to make code easier to understand > - fixed int128 neg > - improved functions bcdcpsgn and bcdsetsgn to do less work > than necessary > - rebased on ppc-for-2.9 >=20 > This serie contains 4 new instructions for POWER9 ISA3.0 >=20 > bcdcfsq.: Convert signed quadword to packed BCD > bcdctsq.: Convert packed BCD to signed quadword > bcdcpsgn.: Copy the sign of a register to another > bcdsetsgn.: Set the BCD sign according to a preferred sign Patch 1/4 has some problems, see comments. Patches 2..4/4 look ok - except that they'll need to be updated for the recent change I merged from Nikunj (in ppc-for-2.9) which changes the meaning of CRF_*. >=20 > Jose Ricardo Ziviani (4): > target-ppc: Implement bcdcfsq. instruction > target-ppc: Implement bcdctsq. instruction > target-ppc: Implement bcdcpsgn. instruction > target-ppc: Implement bcdsetsgn. instruction >=20 > target-ppc/helper.h | 4 ++ > target-ppc/int_helper.c | 127 ++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 25 +++++++ > target-ppc/translate/vmx-ops.inc.c | 2 +- > 4 files changed, 157 insertions(+), 1 deletion(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yPSgZSQ6mfPWgZ9n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYNkJAAAoJEGw4ysog2bOSj14QAMi0vMzd+lqs1cfWKfTR6YN4 Y78NGimsOvgkeyM1PtiEd/h5TExnUI5m4D+f+JxjGLIt/4eyyaI6D8Puv8itHFc1 1bJ0kaZmpLoEKmBh23FMlBLXB7hJJXM3m2lsqhw4J2l2DW/IY8f7FgDa6eMlREAI DKzQxIuReBwSThMBhN3xc99RRTVM9YK7IN0zBw+RwIXbsgegkbgMeCwIDD8dyJft k/VW8QYFYV+SJT+Umf/PvSfeSFNlBCdmlwcuAX6gboG8+4MgCjYeox0FqCFCm5SU WaV21x5HJyzAQt0PrF0L2RQaw8tc+zDMfVnh66xZCXIdGSlga3glbs9wVPMCckVK R7hC+oFzgwMJ2TI/K2IqXizvr+YolyyRMfOWkTZvQhaq+wyTjN6Kh8zJ1UDnHMgu 4FjCt41Be96T8Tn6HRcMwgW1Mu2HSNR3WaGpXEe4FZBJYJsHuChk2LKVMqhcCtFT O+Z06+2EDfqLITGAyRCLhZajH9HAISq8UYj4kAKMklJRLUs1e5RM5XmUGg99qacZ xK4FZIlsuRp7OXaaGvHqdhPwFh/0brZglI3gk/orPHUXN8wGo0L1mPIg26f1Pb9F RGVNQWvhLAIKRfwhTtxz1Fi9OvWcy90L0Y+tGp6GBJHYx+s/29qBoLFoq5CV6EyR NEiiTcavGqzC6rqv8j8R =DUrm -----END PGP SIGNATURE----- --yPSgZSQ6mfPWgZ9n--