From: Peter Xu <peterx@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, alex.williamson@redhat.com
Subject: Re: [Qemu-devel] [PATCH] memory: add section range info for IOMMU notifier
Date: Thu, 24 Nov 2016 20:42:51 +0800 [thread overview]
Message-ID: <20161124124251.GB25010@pxdev.xzpeter.org> (raw)
In-Reply-To: <20161124040435.GA23872@umbus.fritz.box>
On Thu, Nov 24, 2016 at 03:04:35PM +1100, David Gibson wrote:
[...]
> > diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> > index 801578b..c3db115 100644
> > --- a/hw/vfio/common.c
> > +++ b/hw/vfio/common.c
> > @@ -455,6 +455,10 @@ static void vfio_listener_region_add(MemoryListener *listener,
> > giommu->container = container;
> > giommu->n.notify = vfio_iommu_map_notify;
> > giommu->n.notifier_flags = IOMMU_NOTIFIER_ALL;
> > + giommu->n.start = section->offset_within_address_space;
>
> I think this needs to be offset_within_region rather than
> offset_within_address_space. The IOVAs used in the IOMMUTLBEntry are
> relative to the MR, not the enclosing AS (in fact there could be
> several enclosing ASes with the right aliasing). See for example
> put_tce_emu() - the (ioba - tcet->bus_offset) expression is
> effectively converting the AS relative ioba into an MR relative
> address.
Thanks for the pointer. Will fix (and the other place).
-- peterx
prev parent reply other threads:[~2016-11-24 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 9:20 [Qemu-devel] [PATCH] memory: add section range info for IOMMU notifier Peter Xu
2016-11-24 4:04 ` David Gibson
2016-11-24 12:42 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124124251.GB25010@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).