From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9x0j-0003B3-Gc for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:36:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9x0f-0006DC-In for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:36:33 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9x0f-0006Cg-8y for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:36:29 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAOGYPqZ053225 for ; Thu, 24 Nov 2016 11:36:28 -0500 Received: from e24smtp03.br.ibm.com (e24smtp03.br.ibm.com [32.104.18.24]) by mx0a-001b2d01.pphosted.com with ESMTP id 26x0thca80-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 24 Nov 2016 11:36:27 -0500 Received: from localhost by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 Nov 2016 14:36:25 -0200 Date: Thu, 24 Nov 2016 14:36:11 -0200 From: joserz@linux.vnet.ibm.com References: <1479918105-15616-1-git-send-email-joserz@linux.vnet.ibm.com> <20161124012832.GQ17795@umbus.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161124012832.GQ17795@umbus.fritz.box> Message-Id: <20161124163611.GB5922@pacoca> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/4] POWER9 TCG enablements - BCD functions part II List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com David, Thank you again for reviewing my code, I'm making the changes. I only have a question about patch 1/4 which I didn't find the issue so I'm waiting for Richard's answer. Thanks! On Thu, Nov 24, 2016 at 12:28:32PM +1100, David Gibson wrote: > On Wed, Nov 23, 2016 at 02:21:41PM -0200, Jose Ricardo Ziviani wrote: > > v2: > > - use div128 and mul64 functions to make code easier to understand > > - fixed int128 neg > > - improved functions bcdcpsgn and bcdsetsgn to do less work > > than necessary > > - rebased on ppc-for-2.9 > > > > This serie contains 4 new instructions for POWER9 ISA3.0 > > > > bcdcfsq.: Convert signed quadword to packed BCD > > bcdctsq.: Convert packed BCD to signed quadword > > bcdcpsgn.: Copy the sign of a register to another > > bcdsetsgn.: Set the BCD sign according to a preferred sign > > Patch 1/4 has some problems, see comments. > > Patches 2..4/4 look ok - except that they'll need to be updated for > the recent change I merged from Nikunj (in ppc-for-2.9) which changes > the meaning of CRF_*. > > > > > Jose Ricardo Ziviani (4): > > target-ppc: Implement bcdcfsq. instruction > > target-ppc: Implement bcdctsq. instruction > > target-ppc: Implement bcdcpsgn. instruction > > target-ppc: Implement bcdsetsgn. instruction > > > > target-ppc/helper.h | 4 ++ > > target-ppc/int_helper.c | 127 ++++++++++++++++++++++++++++++++++++ > > target-ppc/translate/vmx-impl.inc.c | 25 +++++++ > > target-ppc/translate/vmx-ops.inc.c | 2 +- > > 4 files changed, 157 insertions(+), 1 deletion(-) > > > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson