From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c9x43-0005kB-9e
	for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:40:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c9x42-0000D1-KL
	for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:39:59 -0500
Date: Thu, 24 Nov 2016 17:39:50 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20161124163950.GC4535@noname.redhat.com>
References: <20161115063715.12561-1-pbutsykin@virtuozzo.com>
	<20161115063715.12561-3-pbutsykin@virtuozzo.com>
	<20161123151542.GC5068@noname.redhat.com>
	<58370BBC.1050504@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <58370BBC.1050504@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v1 02/18] block/pcache: empty pcache driver
 filter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Butsykin <pbutsykin@virtuozzo.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, den@openvz.org, famz@redhat.com, stefanha@redhat.com, mreitz@redhat.com, eblake@redhat.com

Am 24.11.2016 um 16:48 hat Pavel Butsykin geschrieben:
> On 23.11.2016 18:15, Kevin Wolf wrote:
> >Am 15.11.2016 um 07:36 hat Pavel Butsykin geschrieben:
> >>+static QemuOptsList runtime_opts = {
> >>+    .name = "pcache",
> >>+    .head = QTAILQ_HEAD_INITIALIZER(runtime_opts.head),
> >>+    .desc = {
> >>+        {
> >>+            .name = "x-image",
> >>+            .type = QEMU_OPT_STRING,
> >>+            .help = "[internal use only, will be removed]",
> >>+        },
> >
> >blkdebug/blkverify have this because they have to support legacy syntax
> >like -drive file=blkdebug:blkdebug.conf:test.img, i.e. it has to deal
> >with filenames.q
> >
> >Here we don't have to support a legacy syntax, so I would completely
> >avoid this from the beginning. You already support the "image" option,
> >which should be good enough.
> 
> Then the command line would look like this:
> 
> -drive file=/img/harddisk.hdd,if=none,id=drive-scsi0-0-0-0,cache=none,aio=native
> -drive driver=pcache,image=scsi0-0-0-0,if=virtio

Yes, either that or with an inline block node definition, the block
layer supports both:

-drive driver=pcache,image.drive=file,image.filename=/img/harddisk.hdd,if=virtio,cache=none,image.aio=native

Kevin