From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cADP0-0005yJ-DW for qemu-devel@nongnu.org; Fri, 25 Nov 2016 05:06:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cADOw-0007SJ-7d for qemu-devel@nongnu.org; Fri, 25 Nov 2016 05:06:42 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cADOv-0007R3-St for qemu-devel@nongnu.org; Fri, 25 Nov 2016 05:06:38 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAPA3gjM072903 for ; Fri, 25 Nov 2016 05:06:36 -0500 Received: from e06smtp06.uk.ibm.com (e06smtp06.uk.ibm.com [195.75.94.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 26xe7u0pun-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 25 Nov 2016 05:06:36 -0500 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Nov 2016 10:06:33 -0000 From: QingFeng Hao Date: Fri, 25 Nov 2016 11:06:29 +0100 In-Reply-To: <20161125100629.88589-1-haoqf@linux.vnet.ibm.com> References: <20161125100629.88589-1-haoqf@linux.vnet.ibm.com> Message-Id: <20161125100629.88589-2-haoqf@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v1 1/1] block/vmdk: Fix the endian problem of buf_len List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, liujbjl@linux.vnet.ibm.com The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian before it was stored to disk. But later vmdk_read_extent read it and converted it from little-endian to cpu endian. If the cpu is big-endian like s390, the problem will happen and the data length read by vmdk_read_extent will become invalid! The fix is to add the conversion in vmdk_write_extent. Signed-off-by: QingFeng Hao Signed-off-by: Jing Liu --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index a11c27a..bf6667f 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1355,7 +1355,7 @@ static int vmdk_write_extent(VmdkExtent *extent, int64_t cluster_offset, } data->lba = offset >> BDRV_SECTOR_BITS; - data->size = buf_len; + data->size = cpu_to_le32(buf_len); n_bytes = buf_len + sizeof(VmdkGrainMarker); iov = (struct iovec) { -- 2.8.4